Skip to content

🧹 [code health improvement] Resolve hardcoded lint ignores - #326

Draft
NITISH-R-G wants to merge 1 commit into
mainfrom
cleanup-lint-ignores-2957650938164490493
Draft

🧹 [code health improvement] Resolve hardcoded lint ignores#326
NITISH-R-G wants to merge 1 commit into
mainfrom
cleanup-lint-ignores-2957650938164490493

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 20, 2026

Copy link
Copy Markdown
Owner

🎯 What:

  • Removed // ignore: unused_field from FamilyCircleService and WebRtcVoiceCallService, resolving the warnings by deleting the unused private fields (_ref) but keeping the constructor contracts (Ref ref) intact.
  • Replaced // ignore: discarded_futures in first_aid_screen.dart with unawaited() from dart:async.
  • Appended header: "" to l10n.yaml to prevent automatic unused_import generation in translated Dart files.
  • Added lib/l10n/** to analyzer: exclude: in analysis_options.yaml.
  • Stripped existing unused_import lines from lib/l10n/*.dart.

💡 Why:
The repository dictates zero usage of hardcoded // ignore: or // ignore_for_file: directives to maintain a pristine, production-ready codebase. Workarounds must be removed in favor of structural solutions or global overrides in analysis_options.yaml.

Verification:

  • dart analyze passes with 0 issues.
  • flutter test passes.
  • Generated app_localizations_*.dart files no longer contain linter overrides.
  • No // ignore: comments remain in lib/.

Result:
Cleaner code, no hidden linter violations, and compliance with the autonomous controller directives.


PR created automatically by Jules for task 2957650938164490493 started by @NITISH-R-G

Summary by Sourcery

Remove hardcoded lint ignores and configure analysis and localization generation to keep the codebase free of generated or inline lint suppressions.

Enhancements:

  • Remove hardcoded lint suppressions by eliminating unused service fields and explicitly marking best-effort asynchronous work as unawaited.
  • Configure localization generation and analyzer exclusions to prevent unused-import lint overrides in generated files.

Chores:

  • Clean existing generated localization files of unused-import suppression comments.

Replaced `// ignore: unused_field` and `// ignore: discarded_futures` with proper fixes.
Configured l10n.yaml and analysis_options.yaml to drop ignores in generated files.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c96e4d3e-f2b4-41a3-8c92-740565c601f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes hardcoded linter // ignore directives by either fixing the underlying issues or moving the suppression to global analyzer configuration, ensuring lint cleanliness without local overrides.

File-Level Changes

Change Details Files
Remove unused Ref fields and associated lint ignores from state notifier services while preserving constructor contracts.
  • Change WebRtcVoiceCallService constructor to accept Ref directly instead of storing a private unused _ref field.
  • Remove assignment to a nullable Ref? _ref field in FamilyCircleService and delete the unused field.
  • Delete local // ignore: unused_field comments tied to these private Ref fields.
lib/services/webrtc_voice_call_service.dart
lib/services/family_circle_service.dart
Replace discarded future ignore with explicit unawaited call for a best-effort side-effect.
  • Wrap FirstAidStore.getVerifiedAdvice(query) in unawaited(...) to mark the intentional fire-and-forget future.
  • Remove // ignore: discarded_futures from the first aid screen side-channel call.
lib/ui/first_aid_screen.dart
Adjust localization generation and analysis configuration to avoid unused_import lints via global tooling configuration instead of inline ignores.
  • Add header: "" to l10n.yaml so generated localization files omit linter override comments.
  • Strip existing // ignore: unused_import lines from all app_localizations_*.dart files under lib/l10n.
  • Add lib/l10n/** to analyzer.exclude in analysis_options.yaml so generated localization code is skipped by the analyzer.
l10n.yaml
analysis_options.yaml
lib/l10n/app_localizations_bn.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_mr.dart
lib/l10n/app_localizations_ta.dart
lib/l10n/app_localizations_te.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant