⚡ Bolt: [performance improvement] Enable virtualization for Activity Log history - #329
⚡ Bolt: [performance improvement] Enable virtualization for Activity Log history#329NITISH-R-G wants to merge 2 commits into
Conversation
Replaced ListView + Column with CustomScrollView + SliverList.builder to enable list virtualization for the activity history. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Reviewer's GuideRefactors SosActivityLogScreen to use a CustomScrollView with sliver-based layout so the activity history list is virtualized, avoiding O(N) rendering, while preserving existing UI structure and behavior for current session and history states. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Replaced ListView + Column with CustomScrollView + SliverList.builder in SosActivityLogScreen to prevent O(N) rendering. Fixed GitHub Actions CI failure by conditionally applying the github-pages environment in health_dashboard.yml. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
💡 What: Replaced
ListView+ColumnwithCustomScrollView+SliverList.builderinSosActivityLogScreen.🎯 Why: The previous implementation wrapped an unbounded history list inside a
Columnwithin aListView. This defeated Flutter's list virtualization, causing all history items to be rendered simultaneously (O(N) rendering). This led to significant UI jank when opening the activity log screen if the user had many saved incidents.📊 Impact: Reduces rendering time complexity from O(N) to O(1) for visible items. Memory usage and first-paint time will remain flat regardless of how many incidents are stored in history.
🔬 Measurement: Run the app, populate the activity history with dozens of incidents, and open the Activity Log screen. It will load instantly without frame drops, whereas the previous implementation would stall.
PR created automatically by Jules for task 6759895365242388771 started by @NITISH-R-G
Summary by Sourcery
Improve activity log performance for large incident histories and prevent pull-request dashboard runs from targeting the deployment environment.
Enhancements:
CI: