Skip to content

⚡ Bolt: [performance improvement] optimize shouldRepaint in MeshRadar #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NITISH-R-G wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: [performance improvement] optimize shouldRepaint in MeshRadar #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/ui/mesh_radar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,5 +214,12 @@ class _SweepingDotPainter extends CustomPainter {
}

@override
bool shouldRepaint(covariant _SweepingDotPainter oldDelegate) => true;
bool shouldRepaint(covariant _SweepingDotPainter oldDelegate) {
// ⚡ Bolt Optimization: Only check static properties (orbitRadius).
// Do not blindly return true, as the animation state already handles
// its own repaints via the `repaint` listenable passed to `super`.
// Returning true here would force a redundant canvas repaint whenever
// the parent widget rebuilds.
return oldDelegate.orbitRadius != orbitRadius;
}
}
Loading