Skip to content

CondonFM Skills - #4

Open
ohadmo wants to merge 6 commits into
mainfrom
omosafi/skills
Open

CondonFM Skills#4
ohadmo wants to merge 6 commits into
mainfrom
omosafi/skills

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This repository is read-only and does not accept Pull Requests. Please open an Issue for reproducible bugs.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo
ohadmo requested a review from caofan September 3, 2026 23:11
@ohadmo ohadmo self-assigned this Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Thanks for your interest. This repository is read-only and does not accept Pull Requests. Please open an Issue for reproducible bugs.

@github-actions github-actions Bot closed this Sep 3, 2026
@ohadmo ohadmo reopened this Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Thanks for your interest. This repository is read-only and does not accept Pull Requests. Please open an Issue for reproducible bugs.

@github-actions github-actions Bot closed this Sep 3, 2026
@ohadmo ohadmo reopened this Sep 4, 2026
@ohadmo

ohadmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the follow-up review’s eligible or outstanding findings.

Summary

  • Adds documented public Encodon workflows and compatibility boundaries.
  • Adds a standard-library RiboNN dataset preparation helper.
  • Updates evaluation checkpoint handling for safetensors and Lightning checkpoints.
  • Adds an NVSkills CI request workflow and adjusts runtime dependencies.

Reviews (4) · Last reviewed commit: "fix prompts due to guardrails"

@ohadmo

ohadmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

1 similar comment
@ohadmo

ohadmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai

@ohadmo

ohadmo commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

1 similar comment
@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@chrisknvidia

Copy link
Copy Markdown

@ohadmo : I did some debugging of the failures,
Suggestion for the resource-intensive Tier 3 evaluations:
Please add the following to skills/codonfm-score/evals/config.yml

schema_version: 1

harbor:
  timeout_multiplier: 4
  sandbox:
    templates:
      claude-code: harbor-eval-claude-code-8g
      codex: harbor-eval-codex-8g
  • timeout_multiplier: 4 applies to both agents.
  • Each template applies to both the with-skill and baseline arm for that agent.
  • The Claude mapping is especially relevant because the latest remaining failure occurred in the Claude baseline.
  • This provides equal resource headroom, but a rerun is still required.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants