refactor(libsy): move escalation router into its own module - #507
Draft
afourniernv wants to merge 1 commit into
Draft
refactor(libsy): move escalation router into its own module#507afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the escalation classifier implementation and its focused tests from
llm_class.rsintoalgorithms/escalation.rs.LlmTaskClassifiercontinues to own the shared route shell and delegates escalation-specific classifier construction to the new private module.Why
The escalation router was embedded in the much larger LLM classifier module, making the implementation and its tests harder to find. Giving it a dedicated algorithm file makes the routing implementations visible from
crates/libsy/src/algorithmsand narrows the responsibility ofllm_class.rs.Linear: SWITCH-1276
How tested
cargo fmt --all --checkcargo test -p switchyard-libsy— 259 passedcargo clippy -p switchyard-libsy --all-targets -- -D warningsRUSTDOCFLAGS='-D warnings' cargo doc -p switchyard-libsy --no-depsChecklist
Notes for reviewers
This is intended to be a structural-only change.
LlmClassifierConfig::Escalation,LlmTaskClassifier, crate-root exports, target ordering, classifier behavior, and the TOML interface remain unchanged. The new module is private;llm_class.rsdelegates construction through a crate-internal helper.