Skip to content

[Common] Remove nv-internal-* comments - #3280

Open
ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:rm_nv_internal_comments
Open

[Common] Remove nv-internal-* comments#3280
ksivaman wants to merge 2 commits into
NVIDIA:mainfrom
ksivaman:rm_nv_internal_comments

Conversation

@ksivaman

Copy link
Copy Markdown
Member

Description

Remove nv-internal-* comments.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Remove nv-internal-* comments.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
ksivaman requested a review from timmoon10 July 29, 2026 21:42
@ksivaman ksivaman added the 2.18 label Jul 29, 2026
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes nv-internal-release annotations from existing scale-factor comments without changing executable CUDA code.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains because the changes only remove comment annotations and do not alter compiled code.

Important Files Changed

Filename Overview
transformer_engine/common/hadamard_transform/graph_safe_group_row_cast_col_hadamard_transform_cast_fusion.cu Removes two internal-release annotations from comments; compiled behavior is unchanged.
transformer_engine/common/hadamard_transform/group_row_cast_col_hadamard_transform_cast_fusion.cu Removes two internal-release annotations from comments; compiled behavior is unchanged.
transformer_engine/common/hadamard_transform/row_cast_col_hadamard_transform_cast_fusion.cu Removes two internal-release annotations from comments; compiled behavior is unchanged.

Reviews (2): Last reviewed commit: "Merge branch 'main' into rm_nv_internal_..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants