Add default metric handling to OSU_Bench reporter - #1028
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe OSU Bench report strategy now supports ChangesOSU Bench metrics
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to OSU Bench reporting now returns average latency for the default and avg_lat metrics while safely rejecting unsupported or unavailable results. The supported and error behaviors are covered, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
srivatsankrishnan
left a comment
There was a problem hiding this comment.
Nice use case from someone outside our team. Great job Alex!
Summary
Update OSUBenchReportGenerationStrategy to support DSE get_metric(). Previous implementation was missing 'default' metric. Now, the average latency (avg_lat) is the selected metric.
Test Plan
Tested DSE of 6 benchmarks, all sucessfully report the avg_latency.
All tests also pass.