[Parsing] Allow workload-specific scenario overrides - #1076
podkidyshev wants to merge 6 commits into
Conversation
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/cloudai/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughScenario serialization now includes explicitly set workload-specific fields. Nemotron FP8 scenarios reference BF16 test configurations and specify FP8 arguments. Documentation describes scenario override limits and removes prior guidance against workload-specific scenario arguments. ChangesScenario workload overrides
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The scenarios preserve the two-node FP8 configuration while reusing the BF16 definition. No actionable merge risk was identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Summary
Scenario entries can override workload-specific test definition fields without adding each field to
TestRunModel. Explicitly supplied workload fields pass through to the existing merge and are validated by the selected workload. Scenario run controls remain separate, and referenced tests still cannot overridetest_template_name.The NeMo Launcher FP8 two-node scenario now references the BF16 test TOML and overrides
cmd_args.training.model.fp8andextra_cmd_args. Both checked-in scenarios that used the duplicate FP8 test file were updated, and the duplicate was removed. The tutorial documents the shared override rule.Test Plan
Additional Notes
N/A