Repository navigation
ci: give the Coverity scan enough CPU and memory to run in parallel - #1084
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe Coverity pipeline comment now describes the toolbox image and tag as matching the release pipeline. Container memory requests and CPU and memory limits have increased. ChangesCoverity scan resources
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Coverity scan receives the increased resources described. No concrete operational or user-facing failure is established, so the change appears ready to merge subject to normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/build |
2d0e827 to
bb02248
Compare
With a 4Gi limit cov-analyze revises from 4 workers to 1 due to memory constraints, so the scan alone takes 22-33 minutes. With 8 CPUs and 32Gi it runs 8 workers and takes about 4.5 minutes; the whole job takes about 5.5. Requests stay small (1 CPU, 4Gi), so the pod still schedules easily. Signed-off-by: Or Balayla <obalayla@nvidia.com>
bb02248 to
8f1ce51
Compare
|
/build |
Summary
The
cloudai-ci-coverityjob takes 23-35 minutes. Almost all of it iscov-analyze: under the 4Gi memory limit it logsand analyzes single-threaded. The 4 CPU/1Gi/4Gi values were carried over from the release pipeline in #1075.
cov-analyzeruns one worker per CPU, and each worker needs its own memory. This raises the Coverity container torequests: {memory: 4Gi, cpu: 1000m},limits: {memory: 32Gi, cpu: 8000m}, so it runs 8 workers. Requests stay small, so the pod still schedules easily.Test Plan
Ran
cloudai-ci-coverityon the same code with each setting. Some runs happened at the same time as 4Gi PR runs; the node kernel shows which kind of node each run landed on:cov-analyzeEvery earlier 4Gi run (#1-#20) also revised to 1 worker. The amount scanned stays the same: about 40.8k-41.0k paths over 5.5k functions in every run.
Additional Notes
The release pipeline's Coverity stage uses the same 4 CPU/4Gi limits and probably has the same slowdown. That pipeline is not changed here.