Skip to content

fix(cuda.bindings): make cythonization warning-clean and enable -Werror #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 5 commits into from
Aug 13, 2026
+3 −1
Merged

fix(cuda.bindings): make cythonization warning-clean and enable -Werror #2463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c707854
fix(cuda.bindings): make cythonization warning-clean and enable -Werror
atiaomar1978-hub Jul 31, 2026
72115e8
Merge branch 'main' into fix/bindings-cython-warning-errors-2450
atiaomar1978-hub Jul 31, 2026
a9f3036
style: ruff-format cython warning cleanliness tests
atiaomar1978-hub Aug 4, 2026
1695c51
test(cuda.bindings): drop cython warning cleanliness tests
atiaomar1978-hub Aug 11, 2026
ce9fb70
Merge branch 'main' into fix/bindings-cython-warning-errors-2450
mdboom Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cuda_bindings/build_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ def _build_cuda_bindings(debug=False):
that metadata queries do not require a CUDA toolkit installation.
"""
from Cython.Build import cythonize
from Cython.Compiler import Options as _CythonOptions

global _extensions

Expand Down Expand Up @@ -230,6 +231,7 @@ def get_static_libraries(f):
)

# Cythonize
_CythonOptions.warning_errors = True
cython_directives = {"language_level": 3, "embedsignature": True, "binding": True, "freethreading_compatible": True}
if compile_for_coverage:
cython_directives["linetrace"] = True
Expand Down
2 changes: 1 addition & 1 deletion cuda_bindings/cuda/bindings/_lib/windll.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ cdef extern from "windows.h" nogil:
ctypedef const char *LPCSTR
ctypedef int BOOL

cdef DWORD LOAD_LIBRARY_SEARCH_SYSTEM32 = 0x00000800
const DWORD LOAD_LIBRARY_SEARCH_SYSTEM32

HMODULE _LoadLibraryExW "LoadLibraryExW"(
LPCWSTR lpLibFileName,
Expand Down
Loading