Skip to content

fix(toolshed): accept // seals so C/C++ generated files can be sealed #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 1 commit into from
Aug 13, 2026
+4 −1
Merged

fix(toolshed): accept // seals so C/C++ generated files can be sealed #2539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion toolshed/check_generated_file_seals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
assert GENERATED_FILE_MARKER_FRAGMENT in GENERATED_FILE_SEAL_TOKEN
_TOKEN_BYTES = GENERATED_FILE_SEAL_TOKEN.encode("ascii")
_MARKER_REGEX = re.compile(
rb"^(?P<prefix>#|\.\.) "
# Keep the alternation in sync with the values of _COMMENT_CHARS below:
# a prefix that is not matched here can never reach the
# expected_comment_prefix() comparison in validate_generated_file_seal().
rb"^(?P<prefix>#|\.\.|//) "
+ re.escape(_TOKEN_BYTES)
+ rb" format=(?P<format>[0-9]+); content-sha256=(?P<digest>[0-9a-f]{64})\n$"
)
Expand Down
Loading