PERF: Inline return code checks in cuda_core - #2608
Merged
Merged
Conversation
mdboom
added
P1
|
mdboom
enabled auto-merge (squash)
August 13, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes ~20ns off of every CUDA API call made in cuda-core using a trick that has existed in cuda_bindings for a few months.
The idea is to inline the check (the comparison to zero) at every call site, and only make a function call to handle raising an exception if you need to.
To avoid making any changes, this is literally just a move of these functions to inline (in the
.pxdfile) and a few declarations to make them work in that context.