Refactor standalone Windows Nsight discovery - #2614
Open
rwgk wants to merge 2 commits into
Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
|
rwgk
marked this pull request as ready for review
August 13, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2609
Extract standalone Windows Nsight product discovery from the generic binary utility finder into
cuda.pathfinder._binaries.windows_nsight.nsysandncucandidate iterators while keeping candidate resolution, executable validation, absolute-path normalization, caching, and search orchestration infind_nvidia_binary_utility.py.ncu.bathandling without eagerly detecting the native Windows machine architecture.This is a semantics-neutral internal refactor. It does not change the public API, candidate precedence, caching, error behavior, path normalization, or observable search order. The existing 1.6.1 release note already covers the user-visible Windows Nsight discovery behavior, so no documentation change is needed.
Testing
TestVenv/bin/python -m pytest cuda_pathfinder/tests(1324 passed, 4 skipped)pre-commit run --all-filesChecklist