Skip to content

Refactor standalone Windows Nsight discovery - #2614

Open
rwgk wants to merge 2 commits into
NVIDIA:mainfrom
rwgk:agent/refactor-windows-nsight-discovery
Open

Refactor standalone Windows Nsight discovery#2614
rwgk wants to merge 2 commits into
NVIDIA:mainfrom
rwgk:agent/refactor-windows-nsight-discovery

Conversation

@rwgk

@rwgk rwgk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #2609

Extract standalone Windows Nsight product discovery from the generic binary utility finder into cuda.pathfinder._binaries.windows_nsight.

  • Move Nsight-specific registry lookup and architecture-specific executable layouts into the dedicated module.
  • Expose lazy nsys and ncu candidate iterators while keeping candidate resolution, executable validation, absolute-path normalization, caching, and search orchestration in find_nvidia_binary_utility.py.
  • Preserve launcher-first ncu.bat handling without eagerly detecting the native Windows machine architecture.
  • Reorganize registry and Nsight-layout tests along the new module boundary while retaining public-finder and search-policy coverage.

This is a semantics-neutral internal refactor. It does not change the public API, candidate precedence, caching, error behavior, path normalization, or observable search order. The existing 1.6.1 release note already covers the user-visible Windows Nsight discovery behavior, so no documentation change is needed.

Testing

  • TestVenv/bin/python -m pytest cuda_pathfinder/tests (1324 passed, 4 skipped)
  • pre-commit run --all-files

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Aug 13, 2026
@rwgk rwgk added the enhancement Any code-related improvements label Aug 13, 2026 — with ChatGPT Codex Connector
@rwgk rwgk added this to the cuda.pathfinder next milestone Aug 13, 2026 — with ChatGPT Codex Connector
@rwgk rwgk self-assigned this Aug 13, 2026
@rwgk rwgk added the P1 Medium priority - Should do label Aug 13, 2026
@rwgk

rwgk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

Copy link
Copy Markdown

@rwgk
rwgk marked this pull request as ready for review August 13, 2026 17:07
@rwgk
rwgk requested a review from isVoid August 13, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor standalone Windows Nsight discovery into a dedicated module

1 participant