Repository navigation
ci: run the NVSkills status check once per pull request - #2144
Merged
Merged
Conversation
On a pull_request event the request job called team-request.yml, whose nested require-nvskills-ci job runs the same shared status workflow as the top-level require-nvskills-ci job. That workflow sets cancel-in-progress on a per-PR concurrency group, so the two copies cancel each other and every PR showed one cancelled check (reported as failed by gh pr checks). Only invoke team-request.yml for the issue_comment and push events it handles. The top-level, non-blocking require-nvskills-ci job stays as the single status check. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ramakrishnap-nv
added
bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description clearly explains the duplicate NVSkills checks, the concurrency cancellation, and the requested workflow change. |
| Title check | |
The title clearly and concisely states the main change: run the NVSkills status check once per pull request. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
CI Test Summary⏭️ All 5 test job(s) skipped. |
KyleFromNVIDIA
approved these changes
Oct 15, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR currently shows one cancelled
NVSkills CI (non-blocking) / require-nvskills-cicheck (gh pr checksreports it as failed).On a
pull_requestevent therequestjob callsteam-request.yml, whose nestedrequire-nvskills-cijob runs the same shared status workflow as the top-levelrequire-nvskills-cijob. That workflow cancels in-progress runs in a per-PR concurrency group, so the two copies cancel each other. In the last five PR runs I checked (#2122, #2138, #2139, #2141, #1972) one copy was cancelled and the other succeeded.This drops
pull_requestfrom therequestjob's condition, so it only handlesissue_commentandpush, which is allteam-request.ymldoes for it. The top-level non-blocking check stays as the single status check, and the/nvskills-ciand signature-push flows are unchanged.This PR's own run should show a single
require-nvskills-cijob.🤖 Generated with Claude Code