test(agent): add generated interface mocks - #408
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded Mockery tooling and Testify dependencies. Added generated mocks for Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
d8efce7 to
2772b92
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent/go/deps.mk`:
- Line 23: Add `unexport MOCKERY_VERSION` immediately after the
`MOCKERY_VERSION` assignment in the Makefile, keeping the variable available for
Makefile expansion while preventing it from being passed to Mockery’s
environment.
In `@agent/go/Makefile`:
- Around line 66-69: Update the generate-mocks target to ensure newly generated
mocks receive the repository’s Apache SPDX license header, since make fmt does
not process untracked files. Configure Mockery with the repository-managed
boilerplate file via .mockery.yaml or run addlicense on the generated mock paths
after $(MOCKERY) completes, while preserving the existing formatting step.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 8cc963a8-4e89-45a1-94ce-f76b76734d9a
⛔ Files ignored due to path filters (1)
agent/go/go.sumis excluded by!**/*.sum
📒 Files selected for processing (9)
agent/go/.mockery.yamlagent/go/Makefileagent/go/deps.mkagent/go/go.modagent/go/internal/config/mock/SchemaValidator.goagent/go/internal/config/validate_test.goagent/go/internal/history/mock/Store.goagent/go/internal/interrupts/mock/Interrupt.goagent/go/internal/step/mock/Step.go
2772b92 to
781de3a
Compare
781de3a to
965cfb7
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
965cfb7 to
7030867
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
7030867 to
cb1ee65
Compare
cb1ee65 to
550cabf
Compare
550cabf to
b66aa26
Compare
3f75318 to
b0005d2
Compare
The merge-base changed after approval.
40a7113 to
dd33a12
Compare
dd33a12 to
02ff54c
Compare
3cbec1d to
8ffcbae
Compare
8ffcbae to
b19c05f
Compare
Pull Request is not mergeable
Pull Request is not mergeable
b19c05f to
4294cbb
Compare
Pull Request is not mergeable
Pull Request is not mergeable
Signed-off-by: Riley Rice <rrice@nvidia.com>
4294cbb to
f8f7275
Compare
Description
Adds reproducible Mockery tooling and generated test doubles for the interfaces used by the final Go agent orchestration layer.
Depends on #407.
Part of #219
Checklist
git commit -s) per the DCO.