-
Notifications
You must be signed in to change notification settings - Fork 261
Create a stdexec module #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ispeters
wants to merge
12
commits into
NVIDIA:main
Choose a base branch
from
ispeters:modularize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create a stdexec module #2138
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2f94227
Bootstrap a broken modules build
ispeters e9f4caa
Almost-working modules build
ispeters 13a0b12
A working build!
ispeters 6475012
Try to put a modules build in the CI matrix
ispeters 74681fc
Fix the modules build
ispeters cd5219c
Try to fix the modules build
ispeters 98b5461
Disable examples in modules build
ispeters 9062630
Apply clang-format v21.1.5
ispeters a0e87eb
Disable more tests
ispeters 8cea155
Add some notes to MAINTAINERS.md
ispeters e3d9829
Undo unconditional test build exclusion
ispeters eb81750
Disable CMake's module scanning in non-module builds
ispeters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ jobs: | |
| - { name: "CPU (clang 16, Release)", build: "Release", tag: llvm16-cuda12.9, cxxstd: "20", cxxflags: "-stdlib=libc++" } | ||
| - { name: "CPU (clang 16, Release, ASAN)", build: "Release", tag: llvm16-cuda12.9, cxxstd: "20", cxxflags: "-stdlib=libc++ -fsanitize=address -fsanitize-ignorelist=/home/coder/stdexec/sanitizer-ignorelist.txt" } | ||
| - { name: "CPU (clang 22, Debug)", build: "Debug", tag: llvm22-cuda13.2, cxxstd: "23", cxxflags: "-stdlib=libc++" } | ||
| - { name: "CPU (clang 22, Debug, modules)", build: "Debug", tag: llvm22-cuda13.2, cxxstd: "23", cxxflags: "-stdlib=libc++" } | ||
| - { name: "CPU (clang 22, Release)", build: "Release", tag: llvm22-cuda13.2, cxxstd: "23", cxxflags: "-stdlib=libc++" } | ||
| - { name: "CPU (clang 22, Release, noexcept)", build: "Release", tag: llvm22-cuda13.2, cxxstd: "23", cxxflags: "-stdlib=libc++ -fno-exceptions" } | ||
| - { name: "CPU (gcc 12, Debug)", build: "Debug", tag: gcc12-cuda12.9, cxxstd: "20", cxxflags: "", } | ||
|
|
@@ -116,6 +117,9 @@ jobs: | |
| -DCMAKE_CXX_STANDARD:STRING=${{ matrix.cxxstd }} \ | ||
| -DCMAKE_CXX_EXTENSIONS:BOOL=OFF \ | ||
| -DSTDEXEC_BUILD_TESTS:BOOL=ON \ | ||
| -DSTDEXEC_BUILD_EXAMPLES:BOOL=${{ !contains(matrix.name, 'modules') }} \ | ||
| -DSTDEXEC_BUILD_MODULES:BOOL=${{ contains(matrix.name, 'modules') }} \ | ||
| -DCMAKE_CXX_STDLIB_MODULES_JSON=/usr/lib/llvm-22/lib/libc++.modules.json \ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is clearly wrong in the long term, but I think it'll unblock CI for now. |
||
| ; | ||
|
|
||
| # Compile | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| if(CMAKE_VERSION VERSION_GREATER_EQUAL "4.3.0") | ||
| set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD | ||
| "451f2fe2-a8a2-47c3-bc32-94786d8fc91b" | ||
| ) | ||
| elseif(CMAKE_VERSION VERSION_GREATER_EQUAL "3.30.0") | ||
| if(CMAKE_VERSION VERSION_LESS "3.31.8") | ||
| set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD | ||
| "0e5b6991-d74f-4b3d-a41c-cf096e0b2508" | ||
| ) | ||
| elseif(CMAKE_VERSION VERSION_LESS "4.0.0") | ||
| set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD | ||
| "d0edc3af-4c50-42ea-a356-e2862fe7a444" | ||
| ) | ||
| elseif(CMAKE_VERSION VERSION_LESS "4.0.3") | ||
| set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD | ||
| "a9e1cf81-9932-4810-974b-6eccaf14e457" | ||
| ) | ||
| elseif(CMAKE_VERSION VERSION_LESS "4.3.0") | ||
| set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD | ||
| "d0edc3af-4c50-42ea-a356-e2862fe7a444" | ||
| ) | ||
| endif() | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of this commit, the examples don't build with modules enabled, so disable them for now.