Skip to content

fix(network): reset_parameters checks nonexistent (+3 more) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusberner merged 1 commit into from
Aug 4, 2026
Merged

fix(network): reset_parameters checks nonexistent (+3 more) #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions fastgen/networks/cosmos_predict2/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@ def forward(
- [output, features]: If feature_indices is non-empty
- (output, logvar): If return_logvar=True
"""
if feature_indices is None:
feature_indices = set()
if return_features_early and len(feature_indices) == 0:
return []

x_B_T_H_W_D, rope_emb_L_1_1_D, extra_pos_emb = self.prepare_embedded_sequence(
x_B_C_T_H_W,
fps=fps,
Expand Down Expand Up @@ -1007,8 +1012,8 @@ def reset_parameters(self):
nn.init.zeros_(m.bias)

# Reinitialize RoPE buffers (non-persistent buffers must be recomputed)
if hasattr(self.transformer, "rope_embedder") and self.transformer.rope_embedder is not None:
rope = self.transformer.rope_embedder
if hasattr(self.transformer, "pos_embedder") and self.transformer.pos_embedder is not None:
rope = self.transformer.pos_embedder
device = next(rope.buffers()).device

# Recompute the sequence buffer
Expand Down Expand Up @@ -1327,7 +1332,7 @@ def forward(
- ([output, features], logvar): If both features and logvar requested
"""
if feature_indices is None:
feature_indices = {}
feature_indices = set()
if return_features_early and len(feature_indices) == 0:
# Exit immediately if user requested this.
return []
Expand Down
Loading