Skip to content

Update Croco repository version #92

Description

@munib94

The current version of the Croco repository that is referenced for InstantSplat does not support later versions of PyTorch.

The error lies here:

InstantSplat/croco/models/curope/kernels.cu(101): error: no suitable conversion function from "const at::DeprecatedTypeProperties" to "c10::ScalarType" exists

Later versions of PyTorch use a modern C++ API where the older function tokens.type() is deprecated and its return value cannot be implicitly converted to c10::ScalarType

The fix was already implemented in the latest version of the Croco repository which was to change line 101 in croco/models/curope/kernels.cu from tokens.type() to tokens.scalar_type()

Can you please update the reference to the latest working branch of the Croco repo?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions