Move Mode of Travel above Course Type in A3 course filters (#1163) - #1164
Open
rustynwac wants to merge 1 commit into
Open
Move Mode of Travel above Course Type in A3 course filters (#1163)#1164rustynwac wants to merge 1 commit into
rustynwac wants to merge 1 commit into
Conversation
Reorder the A3 course embed filter list so Mode of Travel sits directly below Date and above Course Type. Move the last-item `showBottomBorder` suppression from Mode of Travel to Interest Group so the divider styling stays correct. Fixes #1163 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016s7MJjeP8Mr3KRiRA22WwJ
Contributor
|
Preview deployment: https://claudexa3-filter-mode-of-travel-1163.preview.avy-fx.org |
Contributor
Author
ding dong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorders the filter list in the A3 course embed so Mode of Travel sits directly below Date and above Course Type, as requested in #1163.
Before: Date → Course Type → Provider → State → Interest Group → Mode of Travel
After: Date → Mode of Travel → Course Type → Provider → State → Interest Group
Related Issues
Fixes #1163
Key Changes
src/app/(embeds)/embeds/courses/CoursesFilters.tsx— move<ModesOfTravelFilter>to the second position, and move the last-itemshowBottomBorder={false}from it to<AffinityGroupsFilter>(Interest Group), which is now the last filter, so the "no divider under the last filter" styling stays correct.No logic, API, or schema changes.
How to test
pnpm dev, open the courses embed with filters shown:http://localhost:3000/embeds/courses?showFilters=true.Verification performed: loaded the embed in the running dev server and confirmed from the rendered HTML that the filter titles appear in the new order, that Mode of Travel now renders with a
border-bdivider, and that Interest Group (new last item) renders without one.pnpm tsc,pnpm lint, andpnpm fallow:auditall pass.Migration Explanation
None.
Future enhancements / Questions
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_016s7MJjeP8Mr3KRiRA22WwJ
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.