Clear the fallow gate on native-product-pages

[busbyk]

Description

fallow is the only red job on the native-product-pages → main integration PR (#1130), and it is wired into the pre-commit hook, so it has been blocking every commit on this branch — both #1176 and #1183 went in with --no-verify. This clears it.

This is remediation of pre-existing debt spread across issues 01–05. It is deliberately not scoped to any one issue, and nothing here was introduced by #1183.

Stacking: this branch is cut from issue-05b-native-danger-map, so until #1183 merges the diff below includes 05b's commits. It resolves to just the fallow work once #1183 lands. Ordering doesn't matter for CI — ci.yaml only triggers on PRs targeting main, so the fallow job never runs on a PR into native-product-pages; the result shows up on #1130.

Before / after

Measured with fallow audit --changed-since origin/main (166 changed files):

Axis	Before	After
Dead code introduced	37	0
Complexity introduced	15	0
Duplication introduced	6	0
fallow dead-code --baseline	39 issues, exit 1	exit 0
fallow dupes --baseline	exit 0	exit 0
Audit verdict	fail	pass

The baselines are untouched — nothing here was accepted as debt by re-baselining.

Related Issues

Follows the remediation plan in .scratch/native-product-pages/handoffs/fallow-remediation-handoff.md. Unblocks #1130.

Key Changes

Declare the deliberate public surfaces (clears 23 of 39 dead-code findings)

model/forecast.ts exists so the model is the single import surface for consumers, so its re-exports have no consumers of their own and read as dead — transitively taking their sources in types/forecastSchemas.ts with them. Both are now declared in ignoreExports, the same treatment src/components/ui/** already gets.

model/forecast.ts cited "ADR 018" from the start, but that ADR had never been written — docs/decisions/ stopped at 017. It is written here (018-native-product-page-architecture.md), since it is the justification for the config change.

Delete what was genuinely dead

• src/utilities/getUseNativeForecasts.ts — an entire unused file; every call site had already migrated to getNativeProductFlag.
• The unconsumed getProductDataSource re-export in sources/index.ts (the symbol is still used inside the file).
• The ProductListItem alias.

Suppress the z.nativeEnum false positives

Members of AvalancheProblemType, ProductStatus and ExternalMediaType reached only through z.nativeEnum read as unused because zod validates against member values, not by-name references. They are load-bearing — removing WindSlab would make zod reject every forecast carrying a wind-slab problem — so each carries a suppression plus a docblock explaining why. Same pattern as AvalancheCenterType in schemas.ts.

⚠️ fallow fix offers "remove this enum member" as an auto-fix for these. Taking it would break validation of real forecast data.

Waive the two dynamic-segment conflicts

forecast-archive and forecast-freshness hit the same false positive that three sibling routes already waive: fallow reads (payload)/api/[...slug] and api/[center] as one dynamic path, but route groups keep the trees separate.

Complexity: 15 → 0

Mostly by extracting the pure decisions out of components into tested modules — which drops the parent's branch count and covers the logic that moved:

• mediaItem.ts — thumbnail/full URLs, YouTube id, caption, and the slide-kind decision
• datePickerNavigation.ts — month windows, link targets, arrow stepping, the archive fetch
• dangerRatingLayout.ts — day headings and the "no rating" test
• zoneCardDanger.ts — the highest-danger-band lookup
• parseArchiveWindowQuery in archiveDates.ts — the archive endpoint's parameter validation

The JSX-heavy components (DangerScale, AvalancheProblemCard, ForecastDatePicker, NativeForecastView, ZoneForecastCard, MediaLightbox) are split into named sections. MediaSlide moved to its own file so it could be tested without standing up the carousel.

Two incidental fixes fell out: NativeForecastView and ZoneForecastCard each carried their own copy of the highest-danger-band lookup — both now call zoneCardDanger.ts.

63 new tests, all behaviour-preserving refactors.

Duplication: 6 → 0

• src/utilities/centerRoutePage.ts — the per-center route preamble the built-in pages shared verbatim: generateStaticParams, the metadata shape (title suffix, canonical, OpenGraph, dynamic OG image), the Args/PathArgs types, and the platform guard (assertCenterPlatform, which 9 routes hand-rolled).
• src/components/ZoomPanSurface.tsx — the zoom/pan interaction the Gallery block's ZoomableImage and the forecast lightbox's ZoomablePhoto had duplicated.

Not addressed

The 2 circular dependencies through the Payload config barrel. They are rated warn, gate nothing, and are already down from 27 at the July baseline. The only change that actually clears them is injecting payload across ~26 call sites — I tried a lazy await import('@payload-config') first and fallow counts that as a graph edge too, so the cheap version doesn't work. Left as-is deliberately rather than churning hook plumbing for a non-gating finding.

How to test

pnpm fallow:audit --changed-since origin/main   # what CI runs — passes
pnpm fallow:audit --ci                          # what the pre-commit hook runs — passes
./node_modules/.bin/fallow dead-code --baseline fallow-baselines/dead-code.json; echo $?   # 0
./node_modules/.bin/fallow dupes     --baseline fallow-baselines/dupes.json;     echo $?   # 0
pnpm tsc && pnpm lint && pnpm test && pnpm drift:check

All green: 885 tests pass, and this commit went in without --no-verify for the first time on this branch.

Behaviourally this should be a no-op. Worth a click-through of the forecast pages, since that's where the refactoring landed: a zone forecast (danger ratings, problems, media lightbox, date picker), a dated archive view, the all-zones grid, and the Gallery block's lightbox.

Migration Explanation

None — no schema or migration changes.

Future enhancements / Questions

• One behaviour change to flag: weather/forecast/page.tsx used limit: 0 (unlimited) in its generateStaticParams where the other nine routes used limit: 1000. The shared helper normalises to 1000. With four tenants this changes nothing, but it is a real difference and I'd rather name it than bury it.
• Six complexity findings remain inherited (not gated): seed/index.ts:78 (CRAP 1722, 1317 lines) and middleware.ts:49 (1122) are the big ones. They pre-date this branch and are out of scope here.
• The dead-code baseline still lists four symbols in types/schemas.ts that Native avalanche danger map on Mapbox (issue 05, Part B) #1183 deleted. Harmless, but the baselines are due a refresh once this branch merges — worth doing deliberately rather than as a side effect.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[github-actions]

Preview deployment: https://fallow-remediation.preview.avy-fx.org