Skip to content

feat: web-compliant error handling (unhandled rejections, error events, interop.escapeException) #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edusperoni wants to merge 4 commits into
base: feat/update-libffi
Choose a base branch
from
Open

feat: web-compliant error handling (unhandled rejections, error events, interop.escapeException) #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10ea293
feat: track and report unhandled promise rejections
edusperoni Jul 21, 2026
b0a869d
feat: WHATWG error events on globalThis
edusperoni Jul 21, 2026
b36ab05
feat: interop.escapeException and JS-to-native boundary hardening
edusperoni Jul 21, 2026
0d1e372
fix: address review findings (brand liveness, setter wrapper leak, re…
edusperoni Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 109 additions & 42 deletions NativeScript/runtime/ArgConverter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,61 +2,128 @@
#define ArgConverter_h

#include <vector>
#include "libffi.h"
#include "Common.h"

#include "Caches.h"
#include "Common.h"
#include "DataWrapper.h"
#include "IsolateWrapper.h"
#include "libffi.h"

namespace tns {

class ArgConverter;

struct MethodCallbackWrapper {
public:
MethodCallbackWrapper(v8::Isolate* isolate, std::shared_ptr<v8::Persistent<v8::Value>> callback, const uint8_t initialParamIndex, const uint8_t paramsCount, const TypeEncoding* typeEncoding)
: isolateWrapper_(isolate),
callback_(callback),
initialParamIndex_(initialParamIndex),
paramsCount_(paramsCount),
typeEncoding_(typeEncoding) {
}
IsolateWrapper isolateWrapper_;
std::shared_ptr<v8::Persistent<v8::Value>> callback_;
const uint8_t initialParamIndex_;
const uint8_t paramsCount_;
const TypeEncoding* typeEncoding_;
public:
MethodCallbackWrapper(v8::Isolate* isolate,
std::shared_ptr<v8::Persistent<v8::Value>> callback,
const uint8_t initialParamIndex,
const uint8_t paramsCount,
const TypeEncoding* typeEncoding)
: isolateWrapper_(isolate),
callback_(callback),
initialParamIndex_(initialParamIndex),
paramsCount_(paramsCount),
typeEncoding_(typeEncoding) {}
IsolateWrapper isolateWrapper_;
std::shared_ptr<v8::Persistent<v8::Value>> callback_;
const uint8_t initialParamIndex_;
const uint8_t paramsCount_;
const TypeEncoding* typeEncoding_;
};

class ArgConverter {
public:
static void Init(v8::Local<v8::Context> context, v8::GenericNamedPropertyGetterCallback structPropertyGetter, v8::GenericNamedPropertySetterCallback structPropertySetter);
static v8::Local<v8::Value> Invoke(v8::Local<v8::Context> context, Class klass, v8::Local<v8::Object> receiver, V8Args& args, const MethodMeta* meta, bool isMethodCallback);
static v8::Local<v8::Value> ConvertArgument(v8::Local<v8::Context> context, BaseDataWrapper* wrapper, bool skipGCRegistration = false, const std::vector<std::string>& additionalProtocols = std::vector<std::string>());
static v8::Local<v8::Value> CreateJsWrapper(v8::Local<v8::Context> context, BaseDataWrapper* wrapper, v8::Local<v8::Object> receiver, bool skipGCRegistration = false, const std::vector<std::string>& additionalProtocols = std::vector<std::string>());
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyObject(v8::Local<v8::Context> context, bool skipGCRegistration = false);
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyStruct(v8::Local<v8::Context> context);
static const Meta* FindMeta(Class klass, const TypeEncoding* typeEncoding = nullptr);
static const Meta* GetMeta(std::string name);
static const ProtocolMeta* FindProtocolMeta(Protocol* protocol);
static void MethodCallback(ffi_cif* cif, void* retValue, void** argValues, void* userData);
static void SetValue(v8::Local<v8::Context> context, void* retValue, v8::Local<v8::Value> value, const TypeEncoding* typeEncoding);
static void ConstructObject(v8::Local<v8::Context> context, const v8::FunctionCallbackInfo<v8::Value>& info, Class klass, const InterfaceMeta* interfaceMeta = nullptr);
private:
static v8::Local<v8::Function> CreateEmptyInstanceFunction(v8::Local<v8::Context> context, v8::GenericNamedPropertyGetterCallback propertyGetter = nullptr, v8::GenericNamedPropertySetterCallback propertySetter = nullptr);
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyInstance(v8::Local<v8::Context> context, v8::Persistent<v8::Function>* ctorFunc, bool skipGCRegistration = false);
static void FindMethodOverloads(Class klass, std::string methodName, MemberType type, std::vector<const MethodMeta*>& overloads);
static const MethodMeta* FindInitializer(v8::Local<v8::Context> context, Class klass, const InterfaceMeta* interfaceMeta, const v8::FunctionCallbackInfo<v8::Value>& info, std::vector<v8::Local<v8::Value>>& args);
static bool CanInvoke(v8::Local<v8::Context> context, const TypeEncoding* typeEncoding, v8::Local<v8::Value> arg);
static bool CanInvoke(v8::Local<v8::Context> context, const MethodMeta* candidate, const v8::FunctionCallbackInfo<v8::Value>& info);
static std::vector<v8::Local<v8::Value>> GetInitializerArgs(v8::Local<v8::Object> obj, std::string& constructorTokens);
static void IndexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& args);
static void IndexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& args);
static bool IsErrorOutParameter(const TypeEncoding* typeEncoding);
static std::vector<const MethodMeta*> GetInitializers(Caches* cache, Class klass, const InterfaceMeta* interfaceMeta);
static void MethodCallbackInternal(ffi_cif* cif, void* retValue, void** argValues, void* userData);
public:
static void Init(v8::Local<v8::Context> context,
v8::GenericNamedPropertyGetterCallback structPropertyGetter,
v8::GenericNamedPropertySetterCallback structPropertySetter);
static v8::Local<v8::Value> Invoke(v8::Local<v8::Context> context,
Class klass,
v8::Local<v8::Object> receiver,
V8Args& args, const MethodMeta* meta,
bool isMethodCallback);
static v8::Local<v8::Value> ConvertArgument(
v8::Local<v8::Context> context, BaseDataWrapper* wrapper,
bool skipGCRegistration = false,
const std::vector<std::string>& additionalProtocols =
std::vector<std::string>());
static v8::Local<v8::Value> CreateJsWrapper(
v8::Local<v8::Context> context, BaseDataWrapper* wrapper,
v8::Local<v8::Object> receiver, bool skipGCRegistration = false,
const std::vector<std::string>& additionalProtocols =
std::vector<std::string>());
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyObject(
v8::Local<v8::Context> context, bool skipGCRegistration = false);
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyStruct(
v8::Local<v8::Context> context);
static const Meta* FindMeta(Class klass,
const TypeEncoding* typeEncoding = nullptr);
static const Meta* GetMeta(std::string name);
static const ProtocolMeta* FindProtocolMeta(Protocol* protocol);
static void MethodCallback(ffi_cif* cif, void* retValue, void** argValues,
void* userData);
static void SetValue(v8::Local<v8::Context> context, void* retValue,
v8::Local<v8::Value> value,
const TypeEncoding* typeEncoding);
// Returns (lazily creating) the per-isolate interop.escapeException brand
// private stored in Caches. Empty handle if the isolate cache is invalid.
static v8::Local<v8::Private> GetEscapeExceptionBrand(v8::Isolate* isolate);
// If `value` carries the escapeException brand, returns the NSException to
// throw (typed `id` so this header is usable from the pure-C++ TUs that
// include it) — the original wrapped NSException when present, otherwise one
// synthesized from the branded name/message/stack payload. Returns nil when
// `value` is not branded. Never reports; the caller decides what to do.
static id ExtractEscapedException(v8::Local<v8::Context> context,
v8::Local<v8::Value> value);
// Shared JS<->native boundary helper. Reads tc.Exception(): if it carries
// the escapeException brand, returns the NSException (as `id`) the caller
// must @throw AFTER closing every live V8 scope (Locker/HandleScope/
// Context::Scope). Otherwise reports the exception exactly once through the
// uncaught path (error-event dispatch + shims + log) and returns nil, so the
// caller returns its defined default. Resets `tc` in both cases.
static id HandleBoundaryException(v8::Local<v8::Context> context,
v8::TryCatch& tc);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
static void ConstructObject(v8::Local<v8::Context> context,
const v8::FunctionCallbackInfo<v8::Value>& info,
Class klass,
const InterfaceMeta* interfaceMeta = nullptr);

private:
static v8::Local<v8::Function> CreateEmptyInstanceFunction(
v8::Local<v8::Context> context,
v8::GenericNamedPropertyGetterCallback propertyGetter = nullptr,
v8::GenericNamedPropertySetterCallback propertySetter = nullptr);
static std::shared_ptr<v8::Persistent<v8::Value>> CreateEmptyInstance(
v8::Local<v8::Context> context, v8::Persistent<v8::Function>* ctorFunc,
bool skipGCRegistration = false);
static void FindMethodOverloads(Class klass, std::string methodName,
MemberType type,
std::vector<const MethodMeta*>& overloads);
static const MethodMeta* FindInitializer(
v8::Local<v8::Context> context, Class klass,
const InterfaceMeta* interfaceMeta,
const v8::FunctionCallbackInfo<v8::Value>& info,
std::vector<v8::Local<v8::Value>>& args);
static bool CanInvoke(v8::Local<v8::Context> context,
const TypeEncoding* typeEncoding,
v8::Local<v8::Value> arg);
static bool CanInvoke(v8::Local<v8::Context> context,
const MethodMeta* candidate,
const v8::FunctionCallbackInfo<v8::Value>& info);
static std::vector<v8::Local<v8::Value>> GetInitializerArgs(
v8::Local<v8::Object> obj, std::string& constructorTokens);
static void IndexedPropertyGetterCallback(
uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& args);
static void IndexedPropertySetterCallback(
uint32_t index, v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& args);
static bool IsErrorOutParameter(const TypeEncoding* typeEncoding);
static std::vector<const MethodMeta*> GetInitializers(
Caches* cache, Class klass, const InterfaceMeta* interfaceMeta);
static void MethodCallbackInternal(ffi_cif* cif, void* retValue,
void** argValues, void* userData);
};

}
} // namespace tns

#endif /* ArgConverter_h */
Loading
Loading