Fix CMC consensus pose estimation and refinement - #237
Merged
Conversation
vergep
requested changes
Aug 24, 2026
vergep
approved these changes
Aug 25, 2026
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consensus algorithm fixes
Apply the correlation threshold as a post-filter, like the median classifier does.
Fixed
_refineto return the updated inlier set and criterion instead ofNone.Fixed the consensus rotation sign, which was negated relative to the median classifier.
Fixed the consensus translation, which was only valid at the fit centroid. Added
get_translation_aboutto express it around the reference center, and droppedConsensusParameters.translation.Fixed the single-CMC pose, which took
cells[0]instead of the congruent cell.Fill
cell.meta_data, which was left at its defaults. Movedwrap_anglestoutils.pyand wrapped the consensus angle residual too.Report
NaNfor the pose if no consensus geometry