Skip to content

CMC: Resample marks when anisotropic - #243

Merged
cfs-data merged 4 commits into
mainfrom
cmc-resample-marks
Aug 26, 2026
Merged

CMC: Resample marks when anisotropic#243
cfs-data merged 4 commits into
mainfrom
cmc-resample-marks

Conversation

@cfs-data

Copy link
Copy Markdown
Collaborator

No description provided.

@cfs-data
cfs-data requested a review from vergep August 26, 2026 07:28
@cfs-data cfs-data changed the title CMC: resample marks when anisotropic CMC: Resample marks when anisotropic Aug 26, 2026

@vergep vergep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 minor comments

Comment thread packages/scratch-core/src/conversion/surface_comparison/pipeline.py Outdated
Comment thread packages/scratch-core/src/conversion/surface_comparison/utils.py Outdated
Comment thread packages/scratch-core/src/conversion/surface_comparison/utils.py
@github-actions

Copy link
Copy Markdown

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/conversion/surface_comparison/pipeline.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/utils.py (71.4%): Missing lines 121,126
  • src/processors/router.py (100%)

Summary

  • Total: 11 lines
  • Missing: 2 lines
  • Coverage: 81%

packages/scratch-core/src/conversion/surface_comparison/utils.py

Lines 117-130

  117         atol=SCALE_COMPARISON_ATOL,
  118         rtol=SCALE_COMPARISON_RTOL,
  119     ):
  120         return scan_image
! 121     logger.debug(
  122         "Resampling to isotropic: scale_x={:.4g}, scale_y={:.4g}",
  123         scan_image.scale_x,
  124         scan_image.scale_y,
  125     )
! 126     return resample_scan_image_nan_aware(scan_image, scan_image.scale_x)
  127 
  128 
  129 def resolve_nan_fill_value(
  130     reference_image: ScanImage, params: ComparisonParams

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
. 96% 92%
computations 93% 70%
container_models 99% 100%
conversion 95% 88%
conversion.export 99% 90%
conversion.filter 97% 89%
conversion.likelihood_ratio 97% 86%
conversion.preprocess_impression 97% 86%
conversion.preprocess_striation 90% 62%
conversion.profile_correlator 96% 81%
conversion.surface_comparison 97% 84%
conversion.surface_comparison.cell_registration 98% 89%
conversion.surface_comparison.cmc_consensus 100% 100%
extractors 97% 75%
mutations 100% 100%
parsers 97% 50%
parsers.patches 89% 60%
plots 98% 91%
plots.comparison 100% 100%
plots.likelihood_ratio 100% 100%
preprocessors 98% 83%
processors 98% 72%
renders 99% 50%
utils 92% 100%
Summary 97% (3763 / 3860) 86% (455 / 526)

Minimum allowed line rate is 50%

@cfs-data
cfs-data merged commit 3987ff6 into main Aug 26, 2026
4 checks passed
@cfs-data
cfs-data deleted the cmc-resample-marks branch August 26, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants