CMC: Resample marks when anisotropic - #243
Merged
Merged
Conversation
vergep
approved these changes
Aug 26, 2026
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
packages/scratch-core/src/conversion/surface_comparison/utils.pyLines 117-130 117 atol=SCALE_COMPARISON_ATOL,
118 rtol=SCALE_COMPARISON_RTOL,
119 ):
120 return scan_image
! 121 logger.debug(
122 "Resampling to isotropic: scale_x={:.4g}, scale_y={:.4g}",
123 scan_image.scale_x,
124 scan_image.scale_y,
125 )
! 126 return resample_scan_image_nan_aware(scan_image, scan_image.scale_x)
127
128
129 def resolve_nan_fill_value(
130 reference_image: ScanImage, params: ComparisonParams |
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.