Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
18 tasks
Contributor
Author
|
基于本机真实 Hermes Hermes 与已关闭的 Cursor PR 不同:adapter 直接从 实际数据库统计:
我复制同一份真实 DB,在
另外在 PR branch 执行了: 因此建议合入:这是有真实字段命中、可量化收益、且保留未知字段的窄范围 delete-only filter。 |
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Summary
Remove known Hermes runtime/private metadata at the prepared-transcript output boundary while preserving its OpenAI-shaped message and tool semantics.
✅ What does this PR do?
timestampand provider replay fieldscall_id,response_item_id, andextra_contentfrom serializedtool_calls.id, function names/arguments, tool-resulttool_call_id, message content, and unknown future fields.tool_callscontainer shape unchanged and safely leaves malformed or unsupported values untouched.prepare_transcripts()regression.🤔 Why is this change needed?
Hermes prepared transcripts currently retain per-row timestamps and provider-specific replay metadata that are needed by the host runtime but not by memory or skill mining. Hermes already projects its SQLite rows to a narrow OpenAI-shaped schema, so this change filters only the remaining known runtime fields rather than widening or rebuilding that projection.
A read-only validation over the latest 10 local Hermes sessions kept all 202 prepared rows and all 74 tool call/result pairs in the same order while reducing combined output from 345,642 bytes to 324,554 bytes (6.1%). The source database bytes and staged cursor timestamps remained unchanged.
This follows the delete-only, unknown-field-preserving sanitizer contract established by #677, #680, and #681.