Repository navigation
fix: replace @JsonProperty with @JsonIgnore on request getter methods - #22
Closed
fern-api[bot] wants to merge 1 commit into
Closed
fern-api[bot] wants to merge 1 commit into
fern-api[bot] wants to merge 1 commit into
Conversation
Request objects across multiple endpoints used @JsonProperty annotations on getter methods, which caused Jackson to inadvertently serialize request fields into the JSON body when these objects were used in contexts that triggered serialization. Replacing with @JsonIgnore ensures these request POJOs are not accidentally serialized as JSON bodies — parameters are instead passed as query/path parameters via the HTTP layer. Additionally, refactors RetryInterceptor to instantiate a fresh ExponentialBackoff per retry cycle rather than reusing a shared instance, preventing potential state leakage across concurrent or sequential requests. Key changes: - Replace @JsonProperty with @JsonIgnore on all getter methods in GetAggregationCountRequest, GetAuthorsRequest, and GetBreakingNewsRequest - Refactor RetryInterceptor to create a new ExponentialBackoff instance per retryChain() invocation instead of holding a shared instance 🌿 Generated with Fern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Bump: Internal serialization annotation fix and retry interceptor refactor with no observable change to the public API surface or method signatures.
Request objects across multiple endpoints used @JsonProperty annotations
on getter methods, which caused Jackson to inadvertently serialize request
fields into the JSON body when these objects were used in contexts that
triggered serialization. Replacing with @JsonIgnore ensures these request
POJOs are not accidentally serialized as JSON bodies — parameters are
instead passed as query/path parameters via the HTTP layer.
Additionally, refactors RetryInterceptor to instantiate a fresh
ExponentialBackoff per retry cycle rather than reusing a shared instance,
preventing potential state leakage across concurrent or sequential requests.
Key changes:
🌿 Generated with Fern