Repository navigation
fix: replace @JsonProperty with @JsonIgnore on request getter methods - #23
Closed
fern-api[bot] wants to merge 1 commit into
Closed
fern-api[bot] wants to merge 1 commit into
fern-api[bot] wants to merge 1 commit into
Conversation
Request classes across multiple endpoints were incorrectly annotating their getter methods with @JsonProperty, which caused Jackson to attempt to serialize these request objects as JSON bodies. Since these fields are sent as query parameters (not request body fields), they should be excluded from JSON serialization. Replacing @JsonProperty with @JsonIgnore on all getters corrects this behavior across GetAggregationCountRequest, GetAuthorsRequest, and GetBreakingNewsRequest. Additionally, RefactoryInterceptor now creates a fresh ExponentialBackoff instance per retry chain invocation instead of sharing a single instance, preventing potential state leakage between concurrent requests. Key changes: - Replace @JsonProperty with @JsonIgnore on all getter methods in GetAggregationCountRequest, GetAuthorsRequest, and GetBreakingNewsRequest - Create a new ExponentialBackoff instance per retryChain() call in RetryInterceptor instead of reusing a shared instance 🌿 Generated with Fern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Bump: These are internal serialization annotation corrections and a concurrency safety fix with no changes to public method signatures or observable API behavior.
Request classes across multiple endpoints were incorrectly annotating
their getter methods with @JsonProperty, which caused Jackson to attempt
to serialize these request objects as JSON bodies. Since these fields are
sent as query parameters (not request body fields), they should be
excluded from JSON serialization. Replacing @JsonProperty with @JsonIgnore
on all getters corrects this behavior across GetAggregationCountRequest,
GetAuthorsRequest, and GetBreakingNewsRequest.
Additionally, RefactoryInterceptor now creates a fresh ExponentialBackoff
instance per retry chain invocation instead of sharing a single instance,
preventing potential state leakage between concurrent requests.
Key changes:
🌿 Generated with Fern