Repository navigation
feat!: rename NlpDataEntity field and fix GET request serialization - #26
Merged
Merged
Conversation
This release contains a breaking rename in `NlpDataEntity` and a behavioral fix to GET request serialization that restores correct query-parameter transmission. Key changes: - `NlpDataEntity.getSummaryTranslated()` / `Builder.summaryTranslated()` renamed to `getTranslationSummary()` / `translationSummary()`, with the JSON property key changed from `summary_translated` to `translation_summary` - `GetAggregationCountRequest`, `GetAuthorsRequest`, and `GetBreakingNewsRequest` getter annotations changed from `@JsonIgnore` to `@JsonProperty`, restoring correct serialization of all query parameters - `To` union type: deserialization now attempts `String` conversion before `OffsetDateTime`, and the `Visitor` interface method order is swapped accordingly - `PostSearchByLinkRequest`: removed Javadoc from `getFrom()`, `getTo()`, and their builder setters (documentation-only change) 🌿 Generated with Fern
oscatcher
self-requested a review
May 19, 2026 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking: Renaming
NlpDataEntity.getSummaryTranslated()togetTranslationSummary()(and its builder counterpart) removes a public method, breaking all existing callers at compile time.Breaking Changes
NlpDataEntity.getSummaryTranslated()— renamed togetTranslationSummary(); the underlying JSON field also changed fromsummary_translatedtotranslation_summary. Update all call sites to usegetTranslationSummary()andBuilder.translationSummary(...).To.Visitor— thevisit(OffsetDateTime)andvisit(String)method order in theVisitorinterface is swapped; any anonymous or lambda implementations must reorder their overrides accordingly.Fixed
GetAggregationCountRequest,GetAuthorsRequest, andGetBreakingNewsRequest— getter methods were annotated@JsonIgnoreinstead of@JsonProperty, causing all query parameters to be silently dropped from GET requests; they are now correctly annotated and transmitted.See full changelog