Repository navigation
fix: improve SSE line-ending normalization and incremental decoding - #37
Merged
Merged
Conversation
Refactor the SSE event source to use Python's incremental codec decoder for correct multi-byte character handling across chunk boundaries, and add proper normalization of CR, LF, and CRLF line endings per the SSE specification. Also narrows the urllib3 dependency to >=2.6.3. Key changes: - Add `_normalize_sse_line_endings()` to handle \r\n, bare \r, and \n uniformly - Replace one-shot chunk decoding with `codecs.getincrementaldecoder` in both `iter_sse` and `aiter_sse` - Flush incremental decoder at end of stream to avoid dropped trailing bytes - Narrow urllib3 version constraint from `>=1.26.19,<2.0.0 || >=2.2.2,<3.0.0` to `>=2.6.3,<3.0.0` 🌿 Generated with Fern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.1.0 → 2.1.1
Refactor the SSE event source to use Python's incremental codec decoder
for correct multi-byte character handling across chunk boundaries, and
add proper normalization of CR, LF, and CRLF line endings per the SSE
specification. Also narrows the urllib3 dependency to >=2.6.3.
Key changes:
_normalize_sse_line_endings()to handle \r\n, bare \r, and \n uniformlycodecs.getincrementaldecoderin bothiter_sseandaiter_sse>=1.26.19,<2.0.0 || >=2.2.2,<3.0.0to>=2.6.3,<3.0.0🌿 Generated with Fern