Repository navigation
ci: align compile and test jobs with custom logic implemented in sdk - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the sdk-release workflow for the newscatcher SDK — compile and test jobs were copied from catchall and didn't match the newscatcher environment.
Why
Newscatcher has a custom mypy setup and extra type stub dependencies not present in catchall. Running bare
mypy .andpytest -rP .both fail.Changes
mypy.iniconfig with targeted paths instead ofmypy .tests/utilsto skip integration tests that require API keysTesting
workflow_dispatchand confirmed compile, test, and release all pass