Repository navigation
Conversation
… and none primary, installing a lone non-primary one without loading the mod's files, from the spec updated with main_file_version's count
…y requirements, rather than hiding them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse's 1-click install used to fetch a mod's files whenever its main file wasn't marked primary, just to find out whether there was anything to choose. The v3 API now says how many Main files a mod has (flamework#5292), so the picker only opens when there's a real choice.
Warning
Don't merge until production serves
count. As of opening this,GET /v3/mods/{id}doesn't return it yet. Without it,count > 1is false, so a mod with several Main files and no primary would install its newest one without asking.What changes
openapi.yamltaken from flamework master after error: Unknown error (433) Backup couldn't be read: Unknown error (433) #5292. The only difference is the new requiredcountonModMainFileVersion: the mod's Main files that cleared the security scan, including this one.!is_primary && count > 1, as the API PR recommends.Tests
countto try it with.