Repository navigation
fix(crit): open remote reviews over Tailscale - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
“Open in Crit” silently opened nothing when the remote environment was connected over Tailscale rather than SSH. The client omitted forwarding, so Crit tried to open a browser on the server. Reconnecting could also change the active route without changing the preferred saved route.
Open tailnet reviews through temporary, review-owned HTTPS endpoints and choose forwarding from the actual connected route. Crit stays on loopback; closing the review removes only its endpoint. Permission failures can retry with non-interactive sudo when an existing Tailscale file share requires elevated access. Local and SSH/Portless reviews keep their existing paths; unsupported remote routes now report an error instead of silently succeeding.
Test plan
Rollout note
The remote runtime is updated, and the installed Alpha app points at the rebuilt main-checkout artifact. Restart the Mac app to use the new client. Review endpoints are tailnet-only, not Funnel or T3 Connect publications.
The standard remote helper refused this externally launched server. Deployment instead verified its exact PID and staged binary, retained the existing launcher and notification-credential wrapper, and preserved the backend port, public HTTPS origin, and environment identity, with rollback available. No server data migration or credential changes were needed.
brave-tulip-laurel