Repository navigation
fix(speech): pin Prismer 0.1.4 with static Prism - #160
Merged
Merged
Conversation
Remove the obsolete optional-DLL delay-load workaround and verify portable release linkage. nightly: build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin Prismer to 0.1.4 and update prism-sys to 0.1.4, bringing its newer vendored Prism and upstream speech fixes to Windows, macOS, and Linux. Keep the static feature enabled on all platforms and remove PKD's obsolete screen-reader DLL delay-load workaround.
Add a test that actually initializes Prism and a Windows release check that rejects any external Prism DLL dependency before packaging portable builds. Include a changelog entry and nightly build marker.
Validation: formatting and diff checks pass. Local tests were attempted twice but could not finish because the Windows disk ran out of space, including after clearing 2.9 GB of incremental cache. CI must validate the build and tests.