feat: author authentic stone, cobblestone, and diamond ore vector masters

[BharathASL]

Description

Author high-fidelity vector (SVG) masters and un-rotated blockstates for the foundational subterranean blocks: Stone, Cobblestone, and Diamond Ore, matching the official cinematic Minecraft trailer aesthetic.

---

Scope of Work

1. Vector Masters (textures/)

• textures/stone.svg:
  • Clean slate base palette with stylized horizontal striation bars.
  • Primary shapes aligned to the 32px texel grid (16x16 vanilla resolution).
  • Seamless toroidal wrapping for striation bars touching canvas borders ($X=0 \leftrightarrow X=512$).
• textures/cobblestone.svg:
  • Stepped, rounded cobblestone boulders over dark mortar.
  • Seamless Toroidal Tiling: Verified $X$ and $Y$ wrapping so boulders stack and tile without cutoffs, hard seams, or asymmetrical blobs.
  • 2-to-3 tone depth (subtle sunlit highlights and crevice shadows) to match Keyframe trailer art direction.
• textures/diamond_ore.svg:
  • Base Sync: Background striation pattern and corner radius (rx) must be identical to textures/stone.svg so ore blocks blend seamlessly with surrounding stone in caves.
    • Nothing enforces this, and it will drift the first time stone.svg is edited — whoever touches stone gets no signal that a second file depends on it. Add a comment at the top of both SVGs naming the other, and note in the PR whether a build-time assertion in tools/build.mjs is worth adding.
  • Vibrant 2-tone diamond crystal gem overlays (light cyan highlight + deep teal shadow).

2. Blockstate Definitions (pack_template/assets/minecraft/blockstates/)

• pack_template/assets/minecraft/blockstates/stone.json
• pack_template/assets/minecraft/blockstates/cobblestone.json
• pack_template/assets/minecraft/blockstates/diamond_ore.json

Check vanilla before authoring all three. Every blockstate in this pack exists to suppress vanilla's rotation or mirroring, which would break seamless toroidal tiling — the established shape is a single-entry array, as in dirt.json:

{ "variants": { "": [ { "model": "minecraft:block/dirt" } ] } }

stone is varied in vanilla and needs the override. cobblestone and diamond_ore are believed to be single-variant already — verify against the vanilla assets, and drop whichever files would be no-ops rather than shipping overrides that change nothing.

3. Models — none required

Stone, cobblestone and diamond ore all use the vanilla cube model, so no files under pack_template/assets/minecraft/models/block/ are needed. Models are authored here only where a non-default parent applies, as the grass family does with minecraft:block/cross. Stated so the omission reads as deliberate.

---

Technical & Contribution Requirements

Please review the Contributing Guidelines before opening the PR:

• CHANGELOG.md [Unreleased] updated with the blocks added. release.yml fails a stable release when the version has no changelog section, and that failure surfaces at tag time rather than in the PR that caused it.
• Viewport is 512x512 (viewBox="0 0 512 512").
• Toroidal seamless tiling verified on both X and Y axes.
• Primary shapes aligned to the 32px texel grid.
• diamond_ore.svg background matches stone.svg exactly.
• JSON files formatted cleanly with 2 spaces and trailing newlines per .editorconfig.
• Pack compiles cleanly via npm run build.
• Commit message follows Conventional Commits (e.g. feat(textures): author stone, cobblestone, and diamond_ore vector masters).
• Every commit is signed off with DCO (git commit -s).
• Feature branch rebased onto main (no merge commits).

[BharathASL]

Closing as superseded. Nothing here is being dropped — the details of where each part went are below, because one requirement in this issue had no other home and closing it as a plain duplicate would have lost it.

What superseded it. This issue's scope has been re-cut into three Epic 3 tasks, all under the same epic #42 that this issue sits in:

• Task 3.1.1: Primary Stone, Smooth Stone & Infested Stone #70 — Task 3.1.1: Primary Stone, Smooth Stone & Infested Stone
• Task 3.1.2: Cobblestone & Mossy Cobblestone #71 — Task 3.1.2: Cobblestone & Mossy Cobblestone
• Task 3.1.14: Diamond Ore & Deepslate Diamond Ore (Shared Gem Cut) #83 — Task 3.1.14: Diamond Ore & Deepslate Diamond Ore

Those three are better structured for the work: each names its target files explicitly, carries priority, estimate and dependency edges, and each extends the scope rather than merely restating it — #70 adds smooth stone and infested stone, #71 adds mossy cobblestone, #83 adds deepslate diamond ore. Between them they cover everything this issue asked for.

What already shipped. dd538f4 (#39) landed textures/block/stone.svg and textures/block/diamond_ore.svg — plus coal_ore.svg, which was never in this issue's scope — with the stone.json and diamond_ore.json blockstates, and a CHANGELOG.md entry crediting this issue. cobblestone.svg was not authored and is #71's to deliver. Section 3 of this issue was right that no models are needed; that stands and is not repeated in the newer issues.

Where the base-sync contract now lives. This is the part that had no other home. This issue recorded that diamond_ore.svg's background striation pattern and corner radius rx must be identical to stone.svg so ore blocks blend into surrounding stone in caves — and, correctly, that nothing enforced it and it would drift the first time stone.svg was edited, because whoever edits stone gets no signal that other files depend on it. With #79–#87 adding ten more ores on the same base, that exposure multiplies. Neither #70, #71 nor #83 stated it.

It has been carried over before this close, in three places:

1. In the tracker — as a comment on Task 3.1.1: Primary Stone, Smooth Stone & Infested Stone #70, which is where the stone master contract is established and where a future author will look, and cross-referenced from Task 3.1.14: Diamond Ore & Deepslate Diamond Ore (Shared Gem Cut) #83.
2. In the code — feat(build): enforce shared stone-base contract for ore masters #197 adds tools/base-sync.json (registry), tools/lib/base-sync.mjs (verifier), a fatal gate in tools/build.mjs, and tools/test/base-sync.test.mjs. Header comments in stone.svg, coal_ore.svg and diamond_ore.svg name each other and the check.
3. In the contributor docs — CONTRIBUTING.md §3 Ore & Material Consistency.

On the build-time assertion this issue asked to be assessed. It was worth adding, and the reason is specific to this repo rather than a general preference: no workflow runs npm test on a pull request. release.yml is the only workflow that executes repo code and it does so via node tools/build.mjs --all. A check living only in the test suite would have run as often as a contributor remembered to run it, which is the same enforcement the header comment already gave. In the build it is real — a drifted pack cannot compile or be released. Reasoning in full in #197.

Reopen if any of the above turns out to be wrong.

[BharathASL]

Two corrections to the closing comment above, both from things that moved while it was being written. Neither changes the decision to close, but the record should be accurate.

1. "No workflow runs npm test on a pull request" is no longer true. That was correct when written; #196 has since merged as 45f705b, adding .github/workflows/ci.yml, which does run test suites on every pull request. So the premise is now false.

The conclusion is unchanged, and if anything holds more strongly. ci.yml names each suite as its own step rather than invoking npm test wholesale, which means a check added only to the npm test chain still runs nowhere on a pull request — #197 has been updated to add an explicit Shared-Base Contract Test Suite step for exactly that reason. More to the point, the build gate covers a case a PR test never can: release.yml compiles the shipped packs at tag time, and the gate in tools/build.mjs runs there too. A drifted pack cannot be released even by a path that never opened a pull request. The build was the right place for it, for a slightly different reason than the one originally given.

2. Cobblestone's status. The comment says cobblestone "was not authored and is #71's to deliver". At the time of writing #195, feat(textures): author seamless 3D cobblestone vector master (#28), was already open and authoring it. Cobblestone is therefore in flight, not unstarted; #71's remaining scope would be mossy cobblestone and whatever review of #195 concludes. That PR carries Closes #28 in its body, which will now be a no-op against an already-closed issue — worth a look from whoever handles it, along with a path issue I have raised as a comment there.

Everything else in the closing comment stands. This issue stays closed.