chore(deps): declare the npm ecosystem for Dependabot - #213
Merged
Conversation
CI already builds and tests every proposal; the major group exists for rendering changes it cannot assert. Signed-off-by: Bharath Sendhurpandi <bharathasl74185@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependabot here watched
github-actionsand nothing else, so@resvg/resvg-jsandarchiver— the two runtime dependencies this repository ships against, with a committed lockfile — were unwatched. The0 open Dependabot alertsthis repository reports is a consequence of nothing looking, not of a clean tree.templates/dependabot.templateleaves this decision to each repository and asks that it be made "only when someone owns the review". This is that decision, and the trailing note in the file now records it rather than deferring it.The template's caution is about a Minecraft plugin compiled against a specific server API, where a bot raising the version is a compatibility change wearing a security change's clothes. Nothing here is that —
@resvg/resvg-jsandarchiverare ordinary runtime dependencies of a build tool, and neither decides what this repository is compatible with. So there is noignorelist, unlike the plugin repositories.Why the major group is the load-bearing part here
CI carries most of the review.
ci.ymlrunsnpm ci, builds the pack at all five resolutions, and runs the animation, palette, base-sync, tiling-rules and sync-studio suites — so a proposal that breaks the toolchain fails before anyone reads it. That is a materially stronger position thanTextureStudio, which has no build workflow at all.What CI does not assert is rendered output.
@resvg/resvg-jsis a native module, and a major that changes rasterisation would build green, pass every suite, and ship different pixels. Grouping majors separately is what keeps that arriving on its own, to be looked at, instead of riding in with routine patches.Related Issues
None. Raised by an organisation-wide settings and security audit. The same gap is covered for
AntiSpeedrunby Ninja6-MC/AntiSpeedrun#105, forSpiralGenesisby Ninja6-MC/SpiralGenesis#72, and forTextureStudioby Ninja6-MC/TextureStudio#13;brandstill needs the npm equivalent.Type of Change
Checklist
Build and Teston this pull request runsnpm ci, all five pack builds and all five suites against it, which is the stronger check.SessionPulseand againstTextureStudio's npm block, which it matches exactly; GitHub validates the manifest on push and reports a parse failure on the repository's Dependabot page.git commit -s), per section 5 of CONTRIBUTING.md.