feat(hydra): websocket service for live log streaming - #1773
Open
Conni2461 wants to merge 3 commits into
Open
Conversation
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
reviewed
Aug 25, 2026
Member
|
There is an architecture diagram in the docs we should update for this. Please re-run |
Ericson2314
reviewed
Aug 25, 2026
Ericson2314
approved these changes
Aug 25, 2026
Ericson2314
left a comment
Ericson2314
left a comment
Member
There was a problem hiding this comment.
I think I have read enough :) thankfully since this off the "critical path" as a new service, we don't have to be too concerned about things being not quite right --- they won't take down the rest of Hydra
mweinelt
reviewed
Aug 26, 2026
dasJ
reviewed
Aug 26, 2026
|
|
||
| my $step = $c->stash->{step}; | ||
| my $isLive = $step ? $step->busy != 0 : !$c->stash->{build}->finished; | ||
| if ($isLive && $c->config->{'ws_endpoint'}) { |
Member
There was a problem hiding this comment.
This could be one if, combined with the next one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.