Skip to content

luaPackages.lgi: Backport fix for GLib 2.88 - #523825

Merged
mrcjkb merged 1 commit into
NixOS:masterfrom
benaryorg:lgi-awesomewm
May 25, 2026
Merged

mrcjkb merged 1 commit into
NixOS:masterfrom
benaryorg:lgi-awesomewm

Conversation

@benaryorg

@benaryorg benaryorg commented May 25, 2026

Copy link
Copy Markdown
Contributor

This replaces the earlier 2.86 patch.
One may consider bumping the source to something newer than the 8 year old release, but that's out of scope for this fix.


Links:

Vendored because the PR isn't merged yet (at time of writing).
Tested by cherry-picking on top of current nixos-unstable and running awesome (the window manager), so it should work in practice, anyone running nixpkgs-review would be appreciated tho.

Things done

This replaces the earlier 2.86 patch.
One may consider bumping the source to something newer than the 8 year old release, but that's out of scope for this fix.

Signed-off-by: benaryorg <binary@benary.org>
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. labels May 25, 2026
@benaryorg

Copy link
Copy Markdown
Contributor Author

To anyone reading the commit message and wondering about a potential new release; there is an upstream issue from 2019 for maybe tagging a new release.
The "current" release is 0.9.2-1 from 2017.

@benaryorg
benaryorg marked this pull request as ready for review May 25, 2026 01:52
@nixpkgs-ci
nixpkgs-ci Bot requested a review from a team May 25, 2026 02:18
@benaryorg benaryorg added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-26.05 Backport PR automatically labels May 25, 2026
@mrcjkb

mrcjkb commented May 25, 2026

Copy link
Copy Markdown
Member

Based on the discussion in lgi-devs/lgi#225, it looks like there won't be a new release anytime soon, because none of the current maintainers have the necessary permissions (and I presume they don't have access to the luarocks account either).
I'd say this is one of those cases where we should just use the scm-1 rockspec until they figure out how to publish new releases.

@benaryorg

Copy link
Copy Markdown
Contributor Author

I'd say this is one of those cases where we should just use the scm-1 rockspec until they figure out how to publish new releases.

As stated in the commit message, I think that's out-of-scope for this PR.
Since 26.05 has branched off it would be nice if we could get this (which is basically a minimal fix AFAICT) merged and backported to fix the builds, and then do implement any changes to the source repository in a second PR targeting only master.
That'd allow any potential changes (of the past 8 or so years) to first be tested via nixos-unstable and then either end up in a release in 26.11 or via a backport if glib compatibility (or something else) breaks before the next release.

That's just my opinion tho ^^

@mrcjkb

mrcjkb commented May 25, 2026

Copy link
Copy Markdown
Member

Since 26.05 has branched off it would be nice if we could get this (which is basically a minimal fix AFAICT) merged and backported to fix the builds, and then do implement any changes to the source repository in a second PR targeting only master.
That'd allow any potential changes (of the past 8 or so years) to first be tested via nixos-unstable and then either end up in a release in 26.11 or via a backport if glib compatibility (or something else) breaks before the next release.

Sounds reasonable.
Running nixpkgs-review...

Comment thread pkgs/development/lua-modules/overrides.nix
@mrcjkb

mrcjkb commented May 25, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 523825
Commit: 79f6dec101e0ed82160022dde77b88c52c0ff892


x86_64-linux

✅ 53 packages built:
  • awesome
  • awesome.doc
  • boatswain
  • budgie-analogue-clock-applet
  • budgie-control-center
  • budgie-control-center.debug
  • budgie-desktop
  • budgie-desktop-with-plugins
  • budgie-desktop.dev
  • budgie-desktop.man
  • budgie-gsettings-overrides
  • budgie-systemmonitor-applet
  • budgie-user-indicator-redux
  • calls
  • calls.devdoc
  • clapper
  • clapper-enhancers
  • clapper-unwrapped
  • clapper-unwrapped.dev
  • clapper-unwrapped.lib
  • gimp (gimpPlugins.gimp)
  • gimp-with-plugins
  • gimp-with-plugins.man
  • gimp.dev (gimpPlugins.gimp.dev)
  • gimp.devdoc (gimpPlugins.gimp.devdoc)
  • gimp.man (gimpPlugins.gimp.man)
  • gimpPlugins.gmic
  • gimpPlugins.lightning
  • gimpPlugins.resynthesizer
  • gnome-builder
  • gnome-builder.devdoc
  • gnome-manuals
  • ironbar
  • libfoundry
  • libfoundry.dev
  • libfoundry.devdoc
  • libpeas2
  • libpeas2.dev
  • libpeas2.devdoc
  • liferea
  • lua51Packages.lgi
  • luaPackages.lgi (lua52Packages.lgi)
  • lua53Packages.lgi
  • luajitPackages.lgi
  • newsflash
  • pantheon.elementary-code
  • pipeline
  • televido
  • tuba
  • vala-language-server
  • valent
  • vscode-extensions.prince781.vala
  • xapp-thumbnailers

@mrcjkb
mrcjkb added this pull request to the merge queue May 25, 2026
Merged via the queue into NixOS:master with commit 06cdad3 May 25, 2026
39 of 42 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. backport release-26.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: Awesome

2 participants