Write the author display name alongside the service ID

[petergaultney]

🍋:

Comment marks record the author as author="<service-id>", so a mark's display name lives only in the identity provider's user directory. Read a vault without that provider - Relay uninstalled, an export, a plain git checkout, or someone else's clone - and every comment shows a raw user ID with no way to recover who wrote it. The ID is the right thing to key identity on, but it is not durable as a record on its own.

This writes the display name alongside it: {{authorId="<id>" author="<name>">>...<<}}.

That pair is not a new format. getReviewerIdentityForMark in src/main.ts already reads it, with a comment noting that early Relay Comments builds wrote an ID in authorId and a display name in author, and preferring the ID when both are present. Metadata parsing is generic key="value", so the attribute needed no parser change. Only the writer had narrowed to ID-only; this restores the pair, and nothing downstream needed touching.

Marks stay single-attribute where the second value would add nothing: no name available, or a name equal to the ID (the literal-display-name case, where the ID is the name).

Details

• formatAuthoredComment takes an optional authorName. Both values go through one safeAttributeValue guard, so an unsafe value is dropped rather than escaped - same conservative handling the ID already had. An unsafe ID with a safe name now degrades to author="<name>" instead of an unattributed comment; previously the ID was the only channel, so there was nothing to fall back to.
• formatCommentMarkup passes identity.name, suppressed when identity.source === "fallback" so the placeholder "Unknown author" is never written into a file.
• Unit tests cover the pair, both single-attribute paths, and each unsafe-value case.

Not addressed here: date has the same gap in the other direction. formatMarkDate reads and formats metadata.date and the sidebar renders it, but the writer never emits one, so it only appears on hand-written or early-build marks. Happy to add it in a separate change if you want timestamps to be durable too.