Skip to content

ci: stop the test run at the first failure - #101

Merged
NovusEdge merged 1 commit into
mainfrom
chore/ci-failfast
Sep 6, 2026
Merged

NovusEdge merged 1 commit into
mainfrom
chore/ci-failfast

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

The whole workflow takes about 77 seconds, and go test already runs packages
in parallel, so sharding the suite across jobs would buy little. -failfast
stops at the first failing test, which is where the wall-clock time goes on a
broken commit.

Splitting the suite further needs t.Parallel inside internal/recipes, the
long pole. Those tests call t.Setenv, which forbids t.Parallel in the same
test, so that is a larger change than this one.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SXipad3xRhe72PMkoyjBiB

Signed-off-by: NovusEdge <novusedge0@gmail.com>
@NovusEdge NovusEdge self-assigned this Sep 6, 2026
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: d8fc0f12-8a5a-48a9-a47f-026abd5b1230

📥 Commits

Reviewing files that changed from the base of the PR and between ae801cd and b2bcf67.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NovusEdge NovusEdge added the github_actions Pull requests that update GitHub Actions code label Sep 6, 2026
@NovusEdge
NovusEdge merged commit ab48574 into main Sep 6, 2026
7 checks passed
@NovusEdge
NovusEdge deleted the chore/ci-failfast branch September 6, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant