chore: CI lint jobs, templates, policy files

.githooks/pre-commit

@@ -4,6 +4,7 @@ set -e
 [ -f go.mod ] || exit 0        # no Go code yet
 # git ls-files only lists tracked files, so this is already just our own code.
 # The repo does not vendor: it builds from the module cache, same as CI.
+# shellcheck disable=SC2046 # git ls-files output is a list of filenames, splitting is the point
 unformatted=$(gofmt -l $(git ls-files '*.go') 2>/dev/null)
 [ -z "$unformatted" ] || { echo "gofmt needed:"; echo "$unformatted"; exit 1; }
 go vet ./...

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+# Every path requests review from the maintainer. The recipe and docs
+# lines exist so a recipe PR shows who reviews it, even while that is
+# the same person.
+*                            @NovusEdge
+/internal/recipes/bundled/   @NovusEdge
+/docs/recipes/               @NovusEdge

.github/ISSUE_TEMPLATE/bug.yml

@@ -0,0 +1,44 @@
+name: Bug
+description: stoat did something wrong
+labels: [bug]
+body:
+  - type: input
+    id: version
+    attributes:
+      label: stoat version
+      description: Output of `stoat --version`
+    validations:
+      required: true
+  - type: input
+    id: host
+    attributes:
+      label: Host distro and kernel
+      description: Output of `uname -sr` and the distro name
+    validations:
+      required: true
+  - type: input
+    id: guest
+    attributes:
+      label: Guest OS and mode
+      description: For example `alpine live`, `ubuntu cloud`, `debian disk`
+  - type: textarea
+    id: doctor
+    attributes:
+      label: stoat doctor
+      description: Paste the output of `stoat doctor`
+      render: text
+    validations:
+      required: true
+  - type: textarea
+    id: what
+    attributes:
+      label: What happened
+      description: The command or key you pressed, what you expected, what you saw
+    validations:
+      required: true
+  - type: textarea
+    id: log
+    attributes:
+      label: Log tail
+      description: Paste the last 50 lines of `~/.stoat/logs/stoat.log` and, for a provisioning problem, `~/.stoat/<vm>/last-provision.log`
+      render: text

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: true
+contact_links:
+  - name: Security issue
+    url: https://github.com/NovusEdge/stoat/security/advisories/new
+    about: Report a vulnerability privately

.github/ISSUE_TEMPLATE/guest.yml

@@ -0,0 +1,34 @@
+name: Guest OS
+description: Request support for a guest OS
+labels: [guest]
+body:
+  - type: input
+    id: name
+    attributes:
+      label: OS name and version
+    validations:
+      required: true
+  - type: input
+    id: image
+    attributes:
+      label: Cloud image URL
+      description: A qcow2 or raw image with cloud-init, if one exists
+  - type: dropdown
+    id: init
+    attributes:
+      label: Init system
+      options: [systemd, openrc, rc, other]
+    validations:
+      required: true
+  - type: input
+    id: pkg
+    attributes:
+      label: Package manager
+      description: For example `apt`, `dnf`, `pkg`
+    validations:
+      required: true
+  - type: textarea
+    id: notes
+    attributes:
+      label: Notes
+      description: Default ssh user, whether sudo or doas ships, anything the installer needs

.github/ISSUE_TEMPLATE/recipe.yml

@@ -0,0 +1,34 @@
+name: Recipe
+description: A bundled recipe is broken, or you want a new one
+labels: [recipes]
+body:
+  - type: dropdown
+    id: kind
+    attributes:
+      label: Kind
+      options:
+        - A bundled recipe fails
+        - Request for a new recipe
+    validations:
+      required: true
+  - type: input
+    id: recipe
+    attributes:
+      label: Recipe name
+    validations:
+      required: true
+  - type: input
+    id: guest
+    attributes:
+      label: Guest OS and mode
+      description: For example `fedora cloud`
+    validations:
+      required: true
+  - type: textarea
+    id: detail
+    attributes:
+      label: Detail
+      description: For a failure, paste `~/.stoat/<vm>/last-provision.log`. For a request, say what the recipe installs and which guests it should support.
+      render: text
+    validations:
+      required: true

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,17 @@
+## What changed
+
+## Why
+
+## Tests run
+
+- [ ] `just check` and `just test`
+- [ ] `just lint`
+- [ ] live boot or `just e2e` (required for a change under `internal/core`, `internal/sshx`, `internal/cloudinit`, `internal/apkovl`, or a bundled recipe; paste the output below)
+
+## OS matrix
+
+Only for a recipe or guest change. One line per guest OS tested: `alpine: ok`, `debian: not tested`.
+
+## Docs
+
+- [ ] `docs/` updated, or no user-visible change

.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: gomod
+    directory: "/"
+    schedule:
+      interval: weekly
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: weekly

.github/workflows/ci.yml

@@ -12,8 +12,8 @@
     name: check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
         with:
           go-version: '1.26'
 
@@ -35,20 +35,44 @@
       - name: test
         run: go test ./...
 
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
+        with:
+          go-version: '1.26'
+      - uses: golangci/golangci-lint-action@v9
+        with:
+          version: v2.13.2
+
+  shellcheck:
+    name: shellcheck
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: install
+        run: sudo apt-get update -q && sudo apt-get install -y -q shellcheck
+      # Warning level: an info-level note about a quoted variable in a
+      # bundled installer is not worth a red PR.
+      - name: shellcheck
+        run: shellcheck -S warning $(git ls-files 'internal/recipes/bundled/*.sh' 'internal/recipes/bundled/*/*.sh' 'scripts/*.sh' '.githooks/*')
+
   # A separate job because it needs Python rather than Go, and because a
   # failure here should read as "the MCP server broke", not "the Go suite
   # broke". Until this existed, mcp/'s tests ran only on a contributor's
   # machine, so a regression in guards.py (the deterministic blocks that are
   # the whole security boundary, since MCP guarantees nothing itself) would
   # have merged green.
   mcp:
     name: mcp
     runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: mcp
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: actions/setup-python@v5
         with:
           python-version: '3.12'

.github/workflows/e2e.yml

@@ -0,0 +1,24 @@
+name: e2e
+
+# Manual only. scripts/e2e.sh boots a real KVM VM and takes ~15 minutes;
+# no hosted runner has /dev/kvm, so this runs on a self-hosted runner with
+# the `kvm` label. It is the gate for the needs-live-boot label.
+on:
+  workflow_dispatch:
+
+jobs:
+  e2e:
+    name: e2e
+    runs-on: [self-hosted, linux, kvm]
+    timeout-minutes: 40
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
+        with:
+          go-version: '1.26'
+      - name: kvm
+        run: test -r /dev/kvm && test -w /dev/kvm
+      - name: e2e
+        env:
+          STOAT_HOME: ${{ runner.temp }}/stoat-e2e
+        run: ./scripts/e2e.sh

.golangci.yml

@@ -0,0 +1,20 @@
+version: "2"
+linters:
+  enable:
+    - errcheck
+    - staticcheck
+    - govet
+    - unused
+    - misspell
+  settings:
+    errcheck:
+      # A CLI cannot act on a failed write to its own stdout or stderr. The
+      # exclusion keeps every print site free of a two-token discard.
+      exclude-functions:
+        - fmt.Fprint
+        - fmt.Fprintf
+        - fmt.Fprintln
+    staticcheck:
+      # ST and QF rewrite working code for taste. QF1001 turned an allowlist
+      # test into its De Morgan form and broke the comment above it.
+      checks: ["all", "-ST*", "-QF*"]

CODE_OF_CONDUCT.md

@@ -0,0 +1,85 @@
+
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, caste, color, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at a private security advisory at https://github.com/NovusEdge/stoat/security/advisories/new, or an email to the maintainer listed on the GitHub profile. All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.1, available at [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder][Mozilla CoC].
+
+For answers to common questions about this code of conduct, see the FAQ at [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at [https://www.contributor-covenant.org/translations][translations].
+
+[homepage]: https://www.contributor-covenant.org
+[v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html
+[Mozilla CoC]: https://github.com/mozilla/diversity
+[FAQ]: https://www.contributor-covenant.org/faq
+[translations]: https://www.contributor-covenant.org/translations
+

CONTRIBUTING.md

@@ -4,21 +4,22 @@
 
 ```sh
 just setup      # builds, installs to ~/.local/bin, reports missing host deps
-just hooks      # installs the pre-commit and commit-msg hooks
 just dev        # runs the TUI against a scratch STOAT_HOME
 ```
 
+`just setup` also installs the git hooks.
+
 Go 1.26 (pinned in `go.mod`), `just`, and for anything that boots a VM:
 KVM, `qemu-system-x86_64`, `qemu-img`, `ssh`. `stoat doctor` lists what is
-missing.
+missing. `just lint` also needs `golangci-lint` v2 and `shellcheck`.
 
 ## Branches and pull requests
 
 - Branch off `main`. One change per branch.
 - Every PR is squash merged. The PR title becomes the commit subject, so
   write it in the commit grammar below.
-- Sign off every commit (`git commit -s`). The DCO check reads the
-  `Signed-off-by` trailer.
+- Sign off every commit (`git commit -s`). The DCO check on the PR reads
+  the `Signed-off-by` trailer and blocks a merge without it.
 - No `Co-Authored-By` or tool-attribution trailers. The `commit-msg` hook
   strips them.
 - A PR that changes a bundled recipe, a guest, or the boot path gets the
@@ -38,7 +39,9 @@ was found.
 ## Gates
 
 `just check` runs gofmt, `go vet`, and `go build`. The pre-commit hook
-runs the same. CI runs those plus `go test ./...` on every PR.
+runs the same. `just lint` runs golangci-lint and shellcheck. CI runs
+all of those plus `go test ./...` on every PR. The DCO app checks the
+sign-off trailer on every commit in a PR.
 
 ## Tests
 
@@ -74,6 +77,11 @@ A change to a subsystem or an interface another package depends on
 starts as an issue that states the design, discussed before the
 implementation PR. Settled decisions go in `docs/design/`.
 
+`docs/design/core-api.md` §12 holds the conventions a new CLI command
+follows: the `wire` struct behind `--json`, `fail` against `failMsg`, the
+shared `confirm` helper, kong aliases, and `tomlx` for a TOML file. A
+reviewer rejects a PR that ignores them.
+
 ## Recipes
 
 Bundled recipes are `xfce`, `docker`, `devtools`, `tailscale`, and the set