Skip to content

fix: errcheck findings from the guest merge - #58

Merged
NovusEdge merged 1 commit into
mainfrom
fix/lint-on-main
Sep 4, 2026
Merged

NovusEdge merged 1 commit into
mainfrom
fix/lint-on-main

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

main fails lint with four errcheck findings. #48 branched before #47 added the linter, so its code never met the gate. Every open dependabot PR inherits the failure.

  • internal/guest/load.go: the bundled-guest temp file reports a failed Close or Remove instead of dropping it.
  • internal/config/config_test.go: setup failures fail the test.

Tests run

  • golangci-lint run ./...: 0 issues
  • go test ./...

Signed-off-by: NovusEdge <novusedge0@gmail.com>

#48 branched before the linter landed in #47, so its code never met errcheck. The bundled-guest temp file now reports a failed Close or Remove, and the config test fails on a setup error instead of ignoring it.
@NovusEdge NovusEdge added the bug Something isn't working label Sep 4, 2026
@NovusEdge NovusEdge self-assigned this Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 57570aaa-92e6-4d67-9494-cd315ac8f6a9

📥 Commits

Reviewing files that changed from the base of the PR and between 3412c22 and 7fcc451.

📒 Files selected for processing (2)
  • internal/config/config_test.go
  • internal/guest/load.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NovusEdge
NovusEdge merged commit a865364 into main Sep 4, 2026
10 checks passed
@NovusEdge
NovusEdge deleted the fix/lint-on-main branch September 4, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant