Skip to content

test(installer): cover the compact header - #96

Merged
NovusEdge merged 1 commit into
mainfrom
test/installer-header-coverage
Sep 6, 2026
Merged

NovusEdge merged 1 commit into
mainfrom
test/installer-header-coverage

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

The banner collapse from #95 had no test. This adds two.

TestViewTradesTheBannerForHeight pins the rule: a 60-row terminal keeps the
six-line mark, a 10-row terminal trades it for the one-line label, and the
check transcript survives the trade. Breaking the height condition in View
makes it fail, so it holds the behaviour rather than the current output.

TestViewDrawsTheBannerOnce pins that no phase renders the mark's top row
twice.

Two reported defects, both closed as capture artifacts

A visual pass reported a duplicated banner row on the build transition and two
literal tab characters in the ssh row of the check table, both seen through
tmux capture-pane.

Neither is in the rendered output. m.checkTable() contains no tab character
for the same check set, and m.View().Content contains the banner's top row
once in every phase. A pane capture taken mid-redraw shows a partial frame,
which accounts for the duplicate; the tabs come from the capture path.

The second test is the standing guard for the banner half of that.

The banner collapse had no test. One test pins that a tall terminal keeps
the six-line mark, a short one trades it for the one-line label, and the
transcript survives the trade. A second test pins that no phase draws the
mark twice.

Verified by breaking the height condition in View: the first test fails.

Signed-off-by: NovusEdge <novusedge0@gmail.com>
@NovusEdge NovusEdge self-assigned this Sep 6, 2026
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 2c25402e-a2fc-4895-88f0-ffcfc417895f

📥 Commits

Reviewing files that changed from the base of the PR and between 47ec90e and ad170b8.

📒 Files selected for processing (1)
  • internal/installer/tui_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NovusEdge
NovusEdge merged commit e1c55f0 into main Sep 6, 2026
6 checks passed
@NovusEdge
NovusEdge deleted the test/installer-header-coverage branch September 6, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant