test(installer): cover the compact header - #96
Merged
Merged
Conversation
The banner collapse had no test. One test pins that a tall terminal keeps the six-line mark, a short one trades it for the one-line label, and the transcript survives the trade. A second test pins that no phase draws the mark twice. Verified by breaking the height condition in View: the first test fails. Signed-off-by: NovusEdge <novusedge0@gmail.com>
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The banner collapse from #95 had no test. This adds two.
TestViewTradesTheBannerForHeightpins the rule: a 60-row terminal keeps thesix-line mark, a 10-row terminal trades it for the one-line label, and the
check transcript survives the trade. Breaking the height condition in
Viewmakes it fail, so it holds the behaviour rather than the current output.
TestViewDrawsTheBannerOncepins that no phase renders the mark's top rowtwice.
Two reported defects, both closed as capture artifacts
A visual pass reported a duplicated banner row on the build transition and two
literal tab characters in the
sshrow of the check table, both seen throughtmux capture-pane.Neither is in the rendered output.
m.checkTable()contains no tab characterfor the same check set, and
m.View().Contentcontains the banner's top rowonce in every phase. A pane capture taken mid-redraw shows a partial frame,
which accounts for the duplicate; the tabs come from the capture path.
The second test is the standing guard for the banner half of that.