[18.0][FIX] sale_margin_pricelist_computation: Use sale.order.line _get_margin_pricelist_eval_context to test pricelist.item eval context - #278
Merged
OCA-git-bot merged 1 commit intoAug 10, 2026
Conversation
OCA-git-bot
added
mod:sale_margin_pricelist_computation
pedrobaeza
changed the title
pedrobaeza
reviewed
Aug 10, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
This is going to fail if the formula includes a division by one of the variables.
Andrii9090-tecnativa
force-pushed
the
18.0-fix-sale_margin_pricelist_computation-test
branch
from
August 10, 2026 10:35
8ef0c1b to
994a6f7
Compare
pedrobaeza
reviewed
Aug 10, 2026
Contributor
Author
Using dummy data to simulate a real order should avoid this error. |
Andrii9090-tecnativa
force-pushed
the
18.0-fix-sale_margin_pricelist_computation-test
branch
from
August 10, 2026 10:40
994a6f7 to
9feabe3
Compare
…gin_pricelist_eval_context to test pricelist.item eval context TT63968
Andrii9090-tecnativa
force-pushed
the
18.0-fix-sale_margin_pricelist_computation-test
branch
from
August 10, 2026 10:42
9feabe3 to
9d38469
Compare
pedrobaeza
approved these changes
Aug 10, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
We can fast-track it.
/ocabot merge patch
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 0846ed5. Thanks a lot for contributing to OCA. ❤️ |
Andrii9090-tecnativa
deleted the
18.0-fix-sale_margin_pricelist_computation-test
branch
August 10, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows
_get_margin_pricelist_eval_contextto be overridden from other modules, making it possible to extend the evaluation context for each margin formula and evaluate the formula directly frompricelist.item.@pedrobaeza can you review please?
@Tecnativa