Skip to content

[18.0] endpoint: fix lambda - #132

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
camptocamp:18.0-fix-endpoint-create-validate-exec
Jul 30, 2026
Merged

[18.0] endpoint: fix lambda#132
OCA-git-bot merged 1 commit into
OCA:18.0from
camptocamp:18.0-fix-endpoint-create-validate-exec

Conversation

@ivantodorovich

Copy link
Copy Markdown

Backport from the 19.0 migration

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@ivantodorovich

Copy link
Copy Markdown
Author

⚠️ The CI is failing due to an unrelated issue:

2026-05-19 18:58:02,544 316 ERROR odoo odoo.addons.endpoint.tests.test_endpoint: FAIL: TestEndpoint.test_unlink
Traceback (most recent call last):
  File "/opt/odoo-venv/bin/coverage", line 6, in <module>
    sys.exit(main())
  File "/opt/odoo-venv/lib/python3.10/site-packages/coverage/cmdline.py", line 1164, in main
    status = CoverageScript().command_line(argv)
  File "/opt/odoo-venv/lib/python3.10/site-packages/coverage/cmdline.py", line 853, in command_line
    return self.do_run(options, args)
  File "/opt/odoo-venv/lib/python3.10/site-packages/coverage/cmdline.py", line 1043, in do_run
    runner.run()
  File "/opt/odoo-venv/lib/python3.10/site-packages/coverage/execfile.py", line 213, in run
    exec(code, main_mod.__dict__)
  File "/opt/odoo-venv/bin/odoo", line 8, in <module>
    odoo.cli.main()
  File "/opt/odoo/odoo/cli/command.py", line 76, in main
    o.run(args)
  File "/opt/odoo/odoo/cli/server.py", line 182, in run
    main(args)
  File "/opt/odoo/odoo/cli/server.py", line 175, in main
    rc = odoo.service.server.start(preload=preload, stop=stop)
  File "/opt/odoo/odoo/service/server.py", line 1462, in start
    rc = server.run(preload, stop)
  File "/opt/odoo/odoo/service/server.py", line 627, in run
    rc = preload_registries(preload)
  File "/opt/odoo/odoo/service/server.py", line 1393, in preload_registries
    result = loader.run_suite(post_install_suite, global_report=registry._assertion_report)
  File "/opt/odoo/odoo/tests/loader.py", line 118, in run_suite
    suite(results)
AssertionError: Found unexpected attributes on endpoint.endpoint: _endpoint_route_prefix

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simahawk

Copy link
Copy Markdown
Contributor

@ivantodorovich any update?

@ivantodorovich

Copy link
Copy Markdown
Author

This backport is ok.
The CI is broken for other reasons, AFAIK.

AssertionError: Found unexpected attributes on endpoint.endpoint: _endpoint_route_prefix

@simahawk

Copy link
Copy Markdown
Contributor

I see. Have dug a bit into it already? Looks weird because that attribute is the mixin since ages. Probably it comes from that test-apocalypse checking attributes...

@ivantodorovich

Copy link
Copy Markdown
Author

Yeah, it's weird. I didn't look into it, though. In 19.0 it's ok and nothing really changed with the migration AFAICS

@ivantodorovich
ivantodorovich force-pushed the 18.0-fix-endpoint-create-validate-exec branch from 75a4f6b to 2773a33 Compare July 29, 2026 18:44
@ivantodorovich

Copy link
Copy Markdown
Author

@simahawk this is ready to merge now

@simahawk

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-132-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 6b8a77b into OCA:18.0 Jul 30, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7bd2399. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants