Refactor firecracker checksum validation - #104
Merged
Merged
Conversation
So far the --kis-image pull method downloaded a tar file and only verified the checksum of the root filesystem image inside the tarball. However the tarball also contains initrd and kernel files and the kiwi kis build also provides an overall checksum file for the entire archive. This commit refactors the code such that the entire tar file is matched against its checksum. The appstore has been already updated to provide these checksum files along with the actual kis tar files. This Fixes #103
The image is verified against the checksum record fetched from its origin. This Fixes #103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor firecracker checksum validation
So far the --kis-image pull method downloaded a tar file and only verified the checksum of the root filesystem image inside the tarball. However the tarball also contains initrd and kernel files and the kiwi kis build also provides an overall checksum file for the entire archive. This commit refactors the code such that the entire tar file is matched against its checksum. The appstore has been already updated to provide these checksum files along with the actual kis tar files.
Drop extra rootfs image checksum test
The image is verified against the checksum record fetched from its origin.
This Fixes #103