Skip to content

Sync Hide Below between TaskApp and Plugin - #150

Merged
mgerni merged 3 commits into
OSRS-Taskman:masterfrom
LeoFurnari:LeoFurnari/HideTasksBelow
Oct 9, 2026
Merged

mgerni merged 3 commits into
OSRS-Taskman:masterfrom
LeoFurnari:LeoFurnari/HideTasksBelow

Conversation

@LeoFurnari

Copy link
Copy Markdown
Contributor

Utilize Hide Tasks Below configuration to narrow incomplete task criteria. Related pull request: OSRS-Taskman/collection-log-master#164

@rmobis

rmobis commented Oct 8, 2026

Copy link
Copy Markdown
Member

Hey, appreciate you taking time to work on this. However, in order to guarantee this feature makes sense in the whole application context, there are a few points I'd like to see addressed before merging:

  • Official taskers are the main target audience for the plugin and website and ensuring plugin guards against rule violations, even if by mistake, is a hard requirement for any change. Because of this. official taskers should never be allowed to hide tiers or even be presented the option.
  • Given this is a setting about how the tasks are rolled and not merely a visual thing, I think it would be best if it lived directly on the TaskApp database, assigned to your account and editable in your profile. Not only because that's where the rolling happens, but also because this would help provide feature parity between TaskApp and the Collection Log Master plugin.

Doing it this way we could completely remove the option from the plugin settings and pull it directly from the website, on the profile endpoint. We don't need to implement that now, though, so don't worry about this last part.

Would also like to know the opinion of @mgerni and @jdwile. Relevant context is this issue that was introduced when I pushed the TaskApp integration: OSRS-Taskman/collection-log-master#151

Return hideBelow from profile endpoint

Initialize new accounts to default hideBelow of easy

Add Hide Tasks Below dropdown to User Profile, only shown for unofficial accounts.
@mgerni

mgerni commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Agree with @rmobis on both points. The Hide Tasks Below behavior should live on the TaskApp account.

Proposal:

  • Store a minRollTier on the user (default easy; read with .get() so it doesn't need to be backfilled to every user document).
  • We can jank in a radio selection into the profile page (Easy → Master) for Unofficial Taskers only. Official Taskers don't see it. Some light frontend nonsense.
  • generate_task checks is_official: Official Taskers always start at Easy regardless of what's stored.
  • GET /api/v2/user/profile returns min_roll_tier. The plugin reads it from TaskApp instead of from its own config.

@LeoFurnari, if this works for you, your current_rollable_tier(hide_below) change is basically the core of it. I'd hold off on #150/#164 until the profile setting exists, then rework #164 to read from the profile route instead of sending the setting.

Happy to have you take a swing at the TaskApp side if you're interested; otherwise, I'll pick it up.

@LeoFurnari

Copy link
Copy Markdown
Contributor Author

I've already drafted similar changes in [b2fb7c0]. Please review to see if this meets your criteria.

Corresponding changes to the plugin removing the setting there:
OSRS-Taskman/collection-log-master#164

@LeoFurnari LeoFurnari changed the title Receive request body with hide_below to generate-task POST. Sync Hide Below between TaskApp and Plugin Oct 9, 2026
@mgerni

mgerni commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

I've already drafted similar changes in [b2fb7c0]. Please review to see if this meets your criteria.

Corresponding changes to the plugin removing the setting there: OSRS-Taskman/collection-log-master#164

Apologies didn't see your updated commit last night, changes look good to me. @rmobis this cover your concerns surrounding Official Taskers?

@mgerni
mgerni merged commit 6ffef3e into OSRS-Taskman:master Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants