Repository navigation
Sync Hide Below between TaskApp and Plugin - #150
Conversation
…o narrow incomplete task criteria.
|
Hey, appreciate you taking time to work on this. However, in order to guarantee this feature makes sense in the whole application context, there are a few points I'd like to see addressed before merging:
Doing it this way we could completely remove the option from the plugin settings and pull it directly from the website, on the profile endpoint. We don't need to implement that now, though, so don't worry about this last part. Would also like to know the opinion of @mgerni and @jdwile. Relevant context is this issue that was introduced when I pushed the TaskApp integration: OSRS-Taskman/collection-log-master#151 |
Return hideBelow from profile endpoint Initialize new accounts to default hideBelow of easy Add Hide Tasks Below dropdown to User Profile, only shown for unofficial accounts.
|
Agree with @rmobis on both points. The Hide Tasks Below behavior should live on the TaskApp account. Proposal:
@LeoFurnari, if this works for you, your Happy to have you take a swing at the TaskApp side if you're interested; otherwise, I'll pick it up. |
|
I've already drafted similar changes in [b2fb7c0]. Please review to see if this meets your criteria. Corresponding changes to the plugin removing the setting there: |
Apologies didn't see your updated commit last night, changes look good to me. @rmobis this cover your concerns surrounding Official Taskers? |
Utilize Hide Tasks Below configuration to narrow incomplete task criteria. Related pull request: OSRS-Taskman/collection-log-master#164