app: PlaybackController + playhead subscription migration (issues 0c,… - #56
Merged
Merged
Conversation
… 1-4)
New app/playback/playbackcontroller.{h,cpp}: a lazily created
process-wide singleton whose set_playhead() forwards to
oakengine_viewer_set_playhead and re-broadcasts playhead_changed as a
plain Qt signal. Every app-side oakengine_viewer_set_playhead call site
(17 across viewer, timelinewidget, timelineview, import tool,
timebasedwidget, keyframecontrol, export dialog, mainwindow) now goes
through it.
Migrate the first four playhead subscribers off the raw C event
subscription / EngineEventBridge to the controller signal:
- TimeBasedView (issue 1)
- NodeParamViewWidgetBridge (issue 2)
- NodeParamViewKeyframeControl (issue 3)
- NodeParamViewConnectedLabel (issue 4)
Each stores a QMetaObject::Connection filtered on its viewer node and
disconnects on teardown; the viewer_sub_ members are gone. Plan docs
mark issues 0c and 1-4 as done.
Closes OakVideoEditorCommunity#30, closes OakVideoEditorCommunity#31, closes OakVideoEditorCommunity#32, closes OakVideoEditorCommunity#51, closes OakVideoEditorCommunity#52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 1-4)
New app/playback/playbackcontroller.{h,cpp}: a lazily created process-wide singleton whose set_playhead() forwards to oakengine_viewer_set_playhead and re-broadcasts playhead_changed as a plain Qt signal. Every app-side oakengine_viewer_set_playhead call site (17 across viewer, timelinewidget, timelineview, import tool, timebasedwidget, keyframecontrol, export dialog, mainwindow) now goes through it.
Migrate the first four playhead subscribers off the raw C event subscription / EngineEventBridge to the controller signal:
Each stores a QMetaObject::Connection filtered on its viewer node and disconnects on teardown; the viewer_sub_ members are gone. Plan docs mark issues 0c and 1-4 as done.
Closes #30, closes #31, closes #32, closes #51, closes #52.