Skip to content

fix(updates): reuse Android APK after installer dismissal - #401

Open
veryCrunchy wants to merge 6 commits into
mainfrom
fix/android-update-retry
Open

fix(updates): reuse Android APK after installer dismissal#401
veryCrunchy wants to merge 6 commits into
mainfrom
fix/android-update-retry

Conversation

@veryCrunchy

@veryCrunchy veryCrunchy commented Aug 16, 2026

Copy link
Copy Markdown
Member

Outcome

Retain the verified APK after Android opens the system installer. If the user dismisses confirmation, the update card can reopen it without downloading the package again.

Before reuse, the cached APK goes through the same checksum, package identity, version, SDK, and signer verification as a new download. Invalid cached packages are discarded. Coroutine cancellation is preserved, and installer failures retain the current structured, privacy-preserving diagnostics.

The retry action and APK-specific wording appear only for direct-release Android updates. Desktop installer behavior is unchanged. The UI change is integrated into the current AppUpdateSettings component.

Follow-up to #176.

Validation

On the dedicated Linux build host at source head 5b703db23b4520290915c5b8c9f8d34579adfa21, tree f6cfb3e9:

  • AndroidProjectContentClientTest: 14 tests passed.
  • ProjectNewsAndUpdatesTest: 5 tests passed.
  • No failures, errors, or skips in those focused classes.
  • Android and desktop production compilation passed.
  • :androidApp:assembleDebug passed.
  • bash tools/check-repository.sh and git diff --check passed.

The branch includes main at 92dd2ae9cec1dc7dac16907e66d7b870694ebbbf. Hosted checks and regenerated marketing captures are separate merge gates.

Evidence limits

This revision has deterministic test and build coverage. It does not include a device or emulator run that dismisses and reopens Android's system installer, or a signed release upgrade test.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #401 / NC Native August 16, 2026 17:45 Destroyed
@obiente-cloud

obiente-cloud Bot commented Aug 16, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · df52e451e3aa · Ready

Open preview

View in Obiente

Obiente updates this comment as the preview changes.

@veryCrunchy veryCrunchy added priority:P1 Required for the pre-release product experience area:platform Android, desktop, iOS, Windows, macOS, and Linux platform work type:bug platform:android Android-specific implementation or validation labels Aug 16, 2026
@veryCrunchy veryCrunchy added this to the 0.6 Platform polish milestone Aug 16, 2026
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #401 / NC Native August 16, 2026 17:45 Destroyed
@veryCrunchy veryCrunchy moved this to In Progress in Nextcloud Native Roadmap Aug 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6779f096cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudNativeApp.kt Outdated
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #401 / NC Native August 16, 2026 17:52 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #401 / NC Native September 5, 2026 06:21 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #401 / NC Native September 9, 2026 05:12 Destroyed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T05:17:56.682541Z 5b703db New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform Android, desktop, iOS, Windows, macOS, and Linux platform work platform:android Android-specific implementation or validation priority:P1 Required for the pre-release product experience type:bug

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant