Repository navigation
ci: gate runtime advisories and criticals; document unfixable dev-tool highs (#48) - #50
Merged
Merged
Conversation
…l highs (#48) npm audit --audit-level=moderate fails on main because of advisories that cover every published release of the affected package (braces 3.0.3, node-forge 1.4.0), reachable only through local dev/release tooling. audit:ci = npm audit --omit=dev --audit-level=moderate && npm audit --audit-level=critical, used by every workflow; the exception is recorded with advisory IDs and a re-check condition. Closes #48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QQ7W3CkRKEnBpU5KRQUfUu
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
Adversarial review: APPROVE (head b9bb737)Tried to refute the claim that the highs are dev-only and unfixable.
Gate: Tests:
Non-blocking: with no runtime npm deps, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48.
Problem
main CI and the Pages deploy fail at
npm audit --audit-level=moderate. Re-measured 2026-10-14 on origin/main: 3 high, 0 critical, all via @google/clasp -> micromatch -> braces (GHSA-vfj7-8cjw-p6xm). No critical remains (the issue title's criticals are already gone).Every remaining advisory covers all published releases of the package (
braces<=3.0.3 = latest;node-forge<=1.4.0 = latest), so no upgrade oroverridespin clears it. npm's only suggestion is a breaking downgrade.npm audit --omit=dev --audit-level=low->found 0 vulnerabilities.Change
npm run audit:ci=npm audit --omit=dev --audit-level=moderate && npm audit --audit-level=critical; every workflow's audit step calls it.Verification (local)
Expected effect: main CI and the docs/Pages deploy go green; any runtime advisory or any critical still blocks.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QQ7W3CkRKEnBpU5KRQUfUu