Skip to content

ci: pin download-artifact v8.0.2 and assert SHA pinning by shape (supersedes #133) #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlwaldman merged 1 commit into from
Oct 14, 2026
Merged

ci: pin download-artifact v8.0.2 and assert SHA pinning by shape (supersedes #133) #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
id-token: write

steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
- uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8
with:
name: verified-npm-package
path: ${{ runner.temp }}/release-artifact
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
contents: write

steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
- uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8
with:
name: verified-npm-package
path: ${{ runner.temp }}/release-artifact
Expand Down
7 changes: 5 additions & 2 deletions tests/release-readiness.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ describe("release readiness", () => {
const actions = workflow.match(/uses:\s+actions\/[^@\s]+@([^\s#]+)/g) ?? [];

expect(workflow).toContain("Verify release tag matches package version and protected main");
expect(workflow).toContain("actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a");
expect(workflow).toContain("actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c");
// Pin by full commit SHA, but do not hard-code which SHA: Dependabot
// bumps the pin and a literal here turned every such PR red.
expect(workflow).toMatch(/actions\/upload-artifact@[0-9a-f]{40}\s/);
expect(workflow).toMatch(/actions\/download-artifact@[0-9a-f]{40}\s/);
expect(workflow).not.toMatch(/actions\/(?:upload|download)-artifact@v\d/);
expect(workflow).toContain('cp scripts/resolve-npm-publication.mjs "$ARTIFACT_DIR/"');
expect(publishJob).toContain("id-token: write");
expect(publishJob).toContain("sha256sum -c artifact.sha256");
Expand Down
Loading