unify(worldbuilder): Merge Generals and Zero Hour WorldBuilder - #2
Closed
OmarAglan wants to merge 1 commit into
Closed
unify(worldbuilder): Merge Generals and Zero Hour WorldBuilder#2OmarAglan wants to merge 1 commit into
OmarAglan wants to merge 1 commit into
Conversation
OmarAglan
force-pushed
the
unify/worldbuilder-prerequisites
branch
from
July 28, 2026 10:44
f749bac to
628bfe3
Compare
OmarAglan
force-pushed
the
unify/worldbuilder-merge
branch
from
July 28, 2026 10:44
93db098 to
c56bc00
Compare
Owner
Author
|
Superseded by TheSuperHackers#3025. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RTS_GENERALSandRTS_ZEROHOURguards.Why
WorldBuilder had diverged between Generals and Zero Hour. The implementations must be behaviorally aligned before one shared copy can be moved to Core.
Impact
Both games retain their own WorldBuilder targets in this PR, but their 198 source/header files and shared resources are now identical.
Validation
git diff --checkStack
2 of 3. Depends on TheSuperHackers#3024 (
unify/worldbuilder-prerequisites).